Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work without tags #2

Open
minthemiddle opened this issue Aug 8, 2023 · 2 comments
Open

Does not work without tags #2

minthemiddle opened this issue Aug 8, 2023 · 2 comments

Comments

@minthemiddle
Copy link
Owner

I couldn’t make this work for me. If I typed in python review.py areaName, I got an error about not using a tag name. If I typed in python review.py tagName, I got an error about not using an area name.

Edit: What if I want to do this without using tags?

@nathansnelgrove
Copy link

Here's my example:

{
    "areas": {
        "ehc": {
            "tag": "",
            "area_id": "D7xNNhW1XmB56ofhgnmsyb"
        },
        "clientWork": {
            "tag": "",
            "area_id": "HWZHRS6DFbabV14K1Y6gt8"
        }
    },
    "available_areas": ["ehc", "clientWork"]
}

I left the tag field empty because I don't use tags.

@minthemiddle
Copy link
Owner Author

@nathansnelgrove It does not work without tags at the moment, unfortunately.

Right now, the hierarchy is as follows:

  • group - this is the argument how you run and group the review, such as work or private or clients
  • tag - this tag must be on the 1 or many areas that are related to the group
  • area_id - this is the area where you want to save the review

You could get it to work by adding tags to your ehc and clientWork area.
I will also reconsider how I can make it work without tags.
I also consider changing the config to make it clearer and make it simpler.

@minthemiddle minthemiddle changed the title Confusing about areaName and tagName Does not work without tags Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants