Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error out if the php-geos extension is not loaded #15

Open
geertijewski opened this issue Mar 30, 2020 · 0 comments · May be fixed by #16
Open

Error out if the php-geos extension is not loaded #15

geertijewski opened this issue Mar 30, 2020 · 0 comments · May be fixed by #16

Comments

@geertijewski
Copy link

The library just tries to work, without checking if the dependencies have been met. If the library hasn't been loaded, it just fails with the nondescript "ERROR: TimeZone not found". (This might also be the cause for #11)

I think it would be beneficial if the two main classes (UpdaterData and Calculator) would check for the existence of the geos extension and throw if it has not been loaded.
@geertijewski geertijewski linked a pull request Mar 30, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check for existence of geos extension geertijewski/geo-timezone
1 participant
@geertijewski