Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Test Cases: Error Handling for Failing Optimizations and Missing .svg Files #8

Open
1 of 4 tasks
buschtoens opened this issue Jan 21, 2015 · 1 comment
Open
1 of 4 tasks

Missing Test Cases: Error Handling for Failing Optimizations and Missing .svg Files #8

buschtoens opened this issue Jan 21, 2015 · 1 comment
Labels
enhancement help wanted

Comments

@buschtoens
Copy link
Collaborator

If I would know how, I would have written these tests myself, but I couldn't find any resources on writing tests for error / exception handling with broccoli. So the untested cases we have are:

  • Test that ember-inline-svg throws an error during build time, if an SVG optimization has failed.
  • Test that ember-inline-svg emits an "empty" svg.js, if there are no .svg files present.

Another case that is untested:

  • Throw an error, if the handlebars helper could not find the coresponding .svg. StackOverflow
    • Refactor tests

This one is easy to fix tho. Expect a PR soon.
Edit: Not so easy as I thought. Here be StackOverflow.
@buschtoens buschtoens mentioned this issue Jan 21, 2015
Merged
@rlivsey
Copy link
Member

rlivsey commented Jan 21, 2015

Good question, @rwjblue any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlivsey @buschtoens