Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not present on the image #3

Open
VincentMVG opened this issue Aug 20, 2019 · 3 comments
Open

not present on the image #3

VincentMVG opened this issue Aug 20, 2019 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@VincentMVG
Copy link

VincentMVG commented Aug 20, 2019

Hello,

Still following your instructions, the package is not present on my image.
When I check my builddir, no trace of anything about luci-proto-modemmanager nor luci_proto_manager.
The package is selected in the .config file
In the bin folder:
ll openwrt/bin/packages/mips_24kc
drwxr-xr-x 9 xx xx 4096 août 19 12:01 ./
drwxr-xr-x 3 xx xx 4096 août 19 12:21 ../
drwxr-xr-x 2 xx xx 4096 août 20 10:59 base/
drwxr-xr-x 2 xx xx 4096 août 20 11:00 luci/
drwxr-xr-x 2 xx xx 4096 août 19 12:01 luci_proto_modemmanager/
drwxr-xr-x 2 xx xx 4096 août 20 11:06 mobile_broadband/
drwxr-xr-x 2 xx xx 4096 août 20 11:01 packages/
drwxr-xr-x 2 xx xx 4096 août 19 12:01 routing/
drwxr-xr-x 2 xx xx 4096 août 19 12:01 telephony/
xx@xx-VirtualBox:~/xx/openwrt/bin/packages/mips_24kc$ ll luci_proto_modemmanager/
total 24
drwxr-xr-x 2 xx xx 4096 août 19 12:01 ./
drwxr-xr-x 9 xx xx 4096 août 19 12:01 ../
-rw-r--r-- 1 xx xx 1 août 20 11:07 Packages
-rw-r--r-- 1 xx xx 21 août 20 11:07 Packages.gz
-rw-r--r-- 1 xx xx 1 août 20 11:07 Packages.manifest
-rw-r--r-- 1 xx xx 151 août 20 11:07 Packages.sig
xx@xx-VirtualBox:~/xx/openwrt/bin/packages/mips_24kc$ ll luci
total 360
drwxr-xr-x 2 xx xx 4096 août 20 11:00 ./
drwxr-xr-x 9 xx xx 4096 août 19 12:01 ../
-rw-r--r-- 1 xx xx 7416 août 20 10:59 liblucihttp_2019-06-05-91c01c3c-1_mips_24kc.ipk
-rw-r--r-- 1 xx xx 4364 août 20 10:59 liblucihttp-lua_2019-06-05-91c01c3c-1_mips_24kc.ipk
-rw-r--r-- 1 xx xx 11901 août 20 11:00 luci-app-firewall_git-19.170.32094-4d6d8bc-1_all.ipk
-rw-r--r-- 1 xx xx 125276 août 20 11:00 luci-base_git-19.170.32094-4d6d8bc-1_mips_24kc.ipk
-rw-r--r-- 1 xx xx 897 août 20 11:00 luci_git-19.170.32094-4d6d8bc-1_all.ipk
-rw-r--r-- 1 xx xx 11264 août 20 10:59 luci-lib-ip_git-19.170.32094-4d6d8bc-1_mips_24kc.ipk
-rw-r--r-- 1 xx xx 4732 août 20 10:59 luci-lib-jsonc_git-19.170.32094-4d6d8bc-1_mips_24kc.ipk
-rw-r--r-- 1 xx xx 28805 août 20 10:59 luci-lib-nixio_git-19.170.32094-4d6d8bc-1_mips_24kc.ipk
-rw-r--r-- 1 xx xx 80534 août 20 11:00 luci-mod-admin-full_git-19.170.32094-4d6d8bc-1_mips_24kc.ipk
-rw-r--r-- 1 xx xx 2763 août 20 11:00 luci-proto-3g_git-19.170.32094-4d6d8bc-1_all.ipk
-rw-r--r-- 1 xx xx 4421 août 20 10:59 luci-proto-ipv6_git-19.170.32094-4d6d8bc-1_all.ipk
-rw-r--r-- 1 xx xx 3845 août 20 10:59 luci-proto-ppp_git-19.170.32094-4d6d8bc-1_all.ipk
-rw-r--r-- 1 xx xx 2029 août 20 11:00 luci-proto-qmi_git-19.170.32094-4d6d8bc-1_all.ipk
-rw-r--r-- 1 xx xx 12089 août 20 10:59 luci-theme-bootstrap_git-19.170.32094-4d6d8bc-1_all.ipk
-rw-r--r-- 1 xx xx 5499 août 20 11:07 Packages
-rw-r--r-- 1 xx xx 1673 août 20 11:07 Packages.gz
-rw-r--r-- 1 xx xx 6300 août 20 11:07 Packages.manifest
-rw-r--r-- 1 xx xx 151 août 20 11:07 Packages.sig
-rw-r--r-- 1 xx xx 4639 août 20 11:00 rpcd-mod-rrdns_20170710_mips_24kc.ipk
xx@xx-VirtualBox:~/xx/openwrt/bin/packages/mips_24kc$ ll mobile_broadband/
total 1492
drwxr-xr-x 2 xx xx 4096 août 20 11:06 ./
drwxr-xr-x 9 xx xx 4096 août 19 12:01 ../
-rw-r--r-- 1 xx xx 100174 août 20 11:02 libmbim_1.18.2-1_mips_24kc.ipk
-rw-r--r-- 1 xx xx 517523 août 20 11:04 libqmi_1.22.4-1_mips_24kc.ipk
-rw-r--r-- 1 xx xx 879742 août 20 11:06 modemmanager_1.10.0-1_mips_24kc.ipk
-rw-r--r-- 1 xx xx 1520 août 20 11:07 Packages
-rw-r--r-- 1 xx xx 632 août 20 11:07 Packages.gz
-rw-r--r-- 1 xx xx 1815 août 20 11:07 Packages.manifest
-rw-r--r-- 1 xx xx 151 août 20 11:07 Packages.sig

In your package folder, the file 'Packages' is empty, while others contain the list of the packages inthe folder.
Your Makefile might be wrong.

@mips171 mips171 added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 19, 2019
@VincentMVG
Copy link
Author

I managed to include your work in the build from a local git clone, you have to modify the Makefile
I also modified the feeds.conf to point my local deposit.
Here is the diff for the Makefile:

diff --git a/luci-proto-modemmanager/Makefile b/luci-proto-modemmanager/Makefile
index 45ce37d..acba823 100755
--- a/luci-proto-modemmanager/Makefile
+++ b/luci-proto-modemmanager/Makefile
@@ -16,6 +16,7 @@ include $(TOPDIR)/rules.mk
 PKG_NAME:=luci-proto-modemmanager
 PKG_RELEASE:=1
 
+PKG_SRC_DIR := $(shell pwd)
 PKG_BUILD_DIR := $(BUILD_DIR)/$(PKG_NAME)
 
 include $(INCLUDE_DIR)/package.mk
@@ -34,6 +35,9 @@ endef
 
 
 define Build/Prepare
+       mkdir -p $(PKG_BUILD_DIR)
+       cp -r $(PKG_SRC_DIR)/* $(PKG_BUILD_DIR)
+       $(Build/Patch)
 endef
 
 define Build/Configure
@@ -42,5 +46,16 @@ endef
 define Build/Compile
 endef
 
+# Install all our files, including our LuCI replacement files
+define Package/$(PKG_NAME)/install
+       $(INSTALL_DIR) $(1)/usr/lib/lua/luci
+       $(CP) ./luasrc/* $(1)/usr/lib/lua/luci
+endef

This can be a lead to finalise your package.

@ysoyipek
Copy link

I managed to include your work in the build from a local git clone, you have to modify the Makefile
I also modified the feeds.conf to point my local deposit.
Here is the diff for the Makefile:

diff --git a/luci-proto-modemmanager/Makefile b/luci-proto-modemmanager/Makefile
index 45ce37d..acba823 100755
--- a/luci-proto-modemmanager/Makefile
+++ b/luci-proto-modemmanager/Makefile
@@ -16,6 +16,7 @@ include $(TOPDIR)/rules.mk
 PKG_NAME:=luci-proto-modemmanager
 PKG_RELEASE:=1
 
+PKG_SRC_DIR := $(shell pwd)
 PKG_BUILD_DIR := $(BUILD_DIR)/$(PKG_NAME)
 
 include $(INCLUDE_DIR)/package.mk
@@ -34,6 +35,9 @@ endef
 
 
 define Build/Prepare
+       mkdir -p $(PKG_BUILD_DIR)
+       cp -r $(PKG_SRC_DIR)/* $(PKG_BUILD_DIR)
+       $(Build/Patch)
 endef
 
 define Build/Configure
@@ -42,5 +46,16 @@ endef
 define Build/Compile
 endef
 
+# Install all our files, including our LuCI replacement files
+define Package/$(PKG_NAME)/install
+       $(INSTALL_DIR) $(1)/usr/lib/lua/luci
+       $(CP) ./luasrc/* $(1)/usr/lib/lua/luci
+endef

This can be a lead to finalise your package.

I just compiled by applying your patch in the current master branch.
but he gave me other problems. modemmanager compiled but disappeared.

@VincentMVG
Copy link
Author

I don't use the master branch, only the tagged ones (v18.06.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants