Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use close_notify into conduit-lwt-ssl instead a simple shutdown #321

Open
dinosaure opened this issue Sep 29, 2020 · 1 comment
Open

Use close_notify into conduit-lwt-ssl instead a simple shutdown #321

dinosaure opened this issue Sep 29, 2020 · 1 comment

Comments

@dinosaure
Copy link
Member

Currently, we don't try to close nicely an SSL connection with conduit-lwt-ssl, see this code:

let close socket =
Lwt_ssl.ssl_shutdown socket >>= fun () ->
Lwt_ssl.close socket >>= fun () -> Lwt.return_ok ()

#319 highlighted this problem but with #311, we missed this change and we require a release of lwt_ssl/ocaml-ssl. I keep the request as an issue.

@dinosaure
Copy link
Member Author

This issue is lock by ocsigen/lwt_ssl#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant