Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

support django2.0? #32

Open
laiqun opened this issue May 7, 2018 · 7 comments
Open

support django2.0? #32

laiqun opened this issue May 7, 2018 · 7 comments

Comments

@laiqun
Copy link

laiqun commented May 7, 2018

No description provided.

@mishbahr
Copy link
Owner

mishbahr commented May 8, 2018

Pull requests are welcome 😉

What changes do I need to make for django 2.0 compatibility?

@laiqun
Copy link
Author

laiqun commented May 9, 2018

I tried it on django 2.0,some function are not work well.
when I use send mail when register,will cause template error about "users_acitve" cant't be reverse.

The url method may have changed in django 2.0.
code about it:
url(r'^activate/(?P[0-9A-Za-z_-]+)/(?P[0-9A-Za-z]{1,13}-[0-9A-Za-z]{1,20})/$',
activate, name='users_activate'),

@mishbahr
Copy link
Owner

mishbahr commented May 9, 2018

User activation logic is not built in .. its custom view for django-users2
So I don't understand why that would break for django 2.0

Please can you post the full traceback?

@laiqun
Copy link
Author

laiqun commented May 11, 2018

ok,I will reivew the code ;
alreay pull request

@programmerizak
Copy link

Thanks for the package sir, i must say it's very helpful, but am having similar issue with my, the url is url(r'^activate/(?P[0-9A-Za-z_-]+)/(?P[0-9A-Za-z]{1,13}-[0-9A-Za-z]{1,20})/$',
activate, name='users_activate'), . With this in the html {{ protocol }}://{{ site.domain }}{% url 'users_activate' uid token %} am using django2.1 . I have not gone into production. So please sir how can i write the email activation view. if you can just write it here, let me copy and edit it i will be very greatful.

@laiqun
Copy link
Author

laiqun commented Sep 13, 2018

@ImafidonIsaac hi,you can see my "pull request" on this project.
I already fix this bug.

@laiqun
Copy link
Author

laiqun commented Sep 25, 2018

@ImafidonIsaac If you want to solve this problem ,you can see my new pull request. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants