Fix in contract deployment

In evm_host::create(), the evmc::result return object must have the
create_address member set to the new contract address (the VM does
not set it)

If left as 0x0, deployment of contracts by another contract (i.e. at
depth>0) is likely to fail such as in UniswapV3Factory.createPool()

Signed-off-by: Alexander Jung <[email protected]>

Author: AlexRamRam

src/3pc/agent/runners/evm/address.cpp

@@ -34,6 +34,8 @@ namespace cbdc::threepc::agent::runner {
                            const evmc::bytes32& salt,
                            const cbdc::hash_t& bytecode_hash)
         -> evmc::address {
+        // Specs: https://eips.ethereum.org/EIPS/eip-1014
+
         auto new_addr = evmc::address();
         auto buf = cbdc::buffer();
         static constexpr uint8_t contract_address2_preimage_prefix = 0xFF;

src/3pc/agent/runners/evm/host.cpp

@@ -257,6 +257,13 @@ namespace cbdc::threepc::agent::runner {
         auto res = execute(call_msg, msg.input_data, msg.input_size);
 
         if(res.status_code == EVMC_SUCCESS) {
+            // The VM does not populate res.create_address, and it must
+            // set to the address of the new contract.
+            // If left as 0x0, deployment of contracts by another contract
+            // (i.e. depth>0) is likely to fail (e.g.
+            // UniswapV3Factory.createPool())
+            res.create_address = new_addr;
+
             auto maybe_acc = get_account(new_addr, !m_is_readonly_run);
             if(!maybe_acc.has_value()) {
                 maybe_acc = evm_account();