Modify type alias of function bytecode (clarity)

Ammended to reflect type name usage in files associated with runner interface Further ammended because of alias scope Signed-off-by: Michael Maurer <[email protected]>
mit-dci · Apr 5, 2023 · 40c92fd · 40c92fd
1 parent a260bd0
commit 40c92fd
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 9 deletions.
diff --git a/src/3pc/agent/runners/evm/impl.cpp b/src/3pc/agent/runners/evm/impl.cpp
@@ -19,7 +19,7 @@
 namespace cbdc::threepc::agent::runner {
     evm_runner::evm_runner(std::shared_ptr<logging::log> logger,
                            const cbdc::threepc::config& cfg,
-                           runtime_locking_shard::value_type function,
+                           bytecode_type function,
                            parameter_type param,
                            bool is_readonly_run,
                            run_callback_type result_callback,

diff --git a/src/3pc/agent/runners/evm/impl.hpp b/src/3pc/agent/runners/evm/impl.hpp
@@ -49,7 +49,7 @@ namespace cbdc::threepc::agent::runner {
         /// \copydoc interface::interface
         evm_runner(std::shared_ptr<logging::log> logger,
                    const cbdc::threepc::config& cfg,
-                   runtime_locking_shard::value_type function,
+                   bytecode_type function,
                    parameter_type param,
                    bool is_readonly_run,
                    run_callback_type result_callback,

diff --git a/src/3pc/agent/runners/interface.cpp b/src/3pc/agent/runners/interface.cpp
@@ -8,7 +8,7 @@
 namespace cbdc::threepc::agent::runner {
     interface::interface(std::shared_ptr<logging::log> logger,
                          const cbdc::threepc::config& cfg,
-                         runtime_locking_shard::value_type function,
+                         bytecode_type function,
                          parameter_type param,
                          bool is_readonly_run,
                          run_callback_type result_callback,

diff --git a/src/3pc/agent/runners/interface.hpp b/src/3pc/agent/runners/interface.hpp
@@ -16,6 +16,10 @@
 #include <memory>
 
 namespace cbdc::threepc::agent::runner {
+    // type alias for function bytecode
+    using bytecode_type = cbdc::buffer;
+
+
     /// Interface for a contract runner. Subclasses should implement
     /// application logic to enforce specific transaction semantics.
     class interface {
@@ -69,7 +73,7 @@ namespace cbdc::threepc::agent::runner {
         using factory_type = std::function<std::unique_ptr<interface>(
             std::shared_ptr<logging::log> logger,
             const cbdc::threepc::config& cfg,
-            runtime_locking_shard::value_type function,
+            bytecode_type function,
             parameter_type param,
             bool is_readonly_run,
             runner::interface::run_callback_type result_callback,
@@ -95,7 +99,7 @@ namespace cbdc::threepc::agent::runner {
         ///                      runner instance.
         interface(std::shared_ptr<logging::log> logger,
                   const cbdc::threepc::config& cfg,
-                  runtime_locking_shard::value_type function,
+                  bytecode_type function,
                   parameter_type param,
                   bool is_readonly_run,
                   run_callback_type result_callback,
@@ -122,7 +126,7 @@ namespace cbdc::threepc::agent::runner {
       private:
         std::shared_ptr<logging::log> m_log;
         const cbdc::threepc::config& m_cfg;
-        runtime_locking_shard::value_type m_function;
+        bytecode_type m_function;
         parameter_type m_param;
         bool m_is_readonly_run;
         run_callback_type m_result_callback;
@@ -143,7 +147,7 @@ namespace cbdc::threepc::agent::runner {
         static auto
         create(std::shared_ptr<logging::log> logger,
                cbdc::threepc::config cfg,
-               runtime_locking_shard::value_type function,
+               bytecode_type function,
                parameter_type param,
                bool is_readonly_run,
                runner::interface::run_callback_type result_callback,

diff --git a/src/3pc/agent/runners/lua/impl.cpp b/src/3pc/agent/runners/lua/impl.cpp
@@ -22,7 +22,7 @@ namespace cbdc::threepc::agent::runner {
 
     lua_runner::lua_runner(std::shared_ptr<logging::log> logger,
                            const cbdc::threepc::config& cfg,
-                           runtime_locking_shard::value_type function,
+                           bytecode_type function,
                            parameter_type param,
                            bool dry_run,
                            run_callback_type result_callback,

diff --git a/src/3pc/agent/runners/lua/impl.hpp b/src/3pc/agent/runners/lua/impl.hpp
@@ -23,7 +23,7 @@ namespace cbdc::threepc::agent::runner {
         /// \copydoc interface::interface()
         lua_runner(std::shared_ptr<logging::log> logger,
                    const cbdc::threepc::config& cfg,
-                   runtime_locking_shard::value_type function,
+                   bytecode_type function,
                    parameter_type param,
                    bool dry_run,
                    run_callback_type result_callback,