Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable readability-identifier-length lint check? #165

Open
HalosGhost opened this issue Aug 30, 2022 · 3 comments
Open

Enable readability-identifier-length lint check? #165

HalosGhost opened this issue Aug 30, 2022 · 3 comments
Labels
difficulty/01-good-first-issue Very approachable for new contributors enhancement/refactor Improves flexibility/maintainability feedback/question Asking for general feedback on an open-ended question

Comments

@HalosGhost
Copy link
Collaborator

As mentioned in #162, much of the codebase is not compliant with this newly-added clang-tidy check. Looks like the default settings (which we mostly tend to keep) requires that variables names be 3 characters long or longer.

This is as much a question on whether or not we should enable such a stringent check as it is a question of what settings we should enforce.

@HalosGhost HalosGhost added enhancement/refactor Improves flexibility/maintainability difficulty/01-good-first-issue Very approachable for new contributors feedback/question Asking for general feedback on an open-ended question labels Aug 30, 2022
@HalosGhost
Copy link
Collaborator Author

cc @metalicjames

@SumantxD
Copy link

@HalosGhost could you assign me this issue, i would like to work on it

@HalosGhost
Copy link
Collaborator Author

Before you start working on making the code compliant with the check, do you have any thoughts on whether or not the default length is appropriate, or do you think it makes sense to just fit with the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/01-good-first-issue Very approachable for new contributors enhancement/refactor Improves flexibility/maintainability feedback/question Asking for general feedback on an open-ended question
Projects
None yet
Development

No branches or pull requests

2 participants