feat: implement submit chunking for RFD 0010 #731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
patrickjcasey
force-pushed
the
patrickjcasey/rfd10-proto-changes
branch
from
073eb25 to
d892eb3
Compare
|
Marked as a draft but I got an email saying you requested review. When the branch is ready can you remove the draft marker |
patrickjcasey
force-pushed
the
patrickjcasey/rfd10-proto-changes
branch
from
d892eb3 to
26d697a
Compare
patrickjcasey
force-pushed
the
patrickjcasey/rfd10-proto-changes
branch
from
26d697a to
a02ceea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this branch, my only outstanding question pertaint to
hipcheck-common/proto/hipcheck/v1/hipcheck.proto. DoesQUERY_STATE_SUBMIT_IN_PROGRESSneed to be 4 because 0-3 have already been assigned previously and is adding a variant to an enum backwards compatiblecloses #730 #732