Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For beginners: Change TEST_MSG_MAXSIZE into a run-time limit. #33

Open
mity opened this issue Jan 11, 2020 · 1 comment · May be fixed by #83
Open

For beginners: Change TEST_MSG_MAXSIZE into a run-time limit. #33

mity opened this issue Jan 11, 2020 · 1 comment · May be fixed by #83
Labels
enhancement good first issue Feasible for new contributors.

Comments

@mity
Copy link
Owner

mity commented Jan 11, 2020

Currently, there is a compile-time constant limiting length of helper messages output via TEST_MSG macro. It would be good to change it so that people do not have to re-compile of they need to see longer message.

Because Acutest should not output too long things by default, it still should have a limit, but it should be changed into run-time one. I'd suggest that TEST_MSG_MAXSIZE will be kept but will only determine the default length and user could specify another one by a new command line option, say --max-msg=NUMBER.
@mity mity added the good first issue Feasible for new contributors. label Jan 11, 2020
@mity mity changed the title Idea for beginners: Change TEST_MSG_MAXSIZE into a run-time limit. For beginners: Change TEST_MSG_MAXSIZE into a run-time limit. Jan 11, 2020
@mity mity mentioned this issue Jan 11, 2020
Open
@RosscoG
Copy link

RosscoG commented Nov 30, 2024

Hi @mity. Thank you for acutest, I've used if for years as my goto for any C I write.

I'm working on this issue now as my intro to open source contributions. I understand it's a pretty simple feature, but I'm comprehensively documenting the process as practice and to add to the pull request. I'm new to working on open source projects, so any feedback will be appreciated.

I see the equivalent issue for TEST_DUMP_MAXSIZE, #34.
Once this one is done, would you like that to also be implemented for consistency, or leave it for another beginner?

RosscoG added a commit to RosscoG/acutest that referenced this issue Nov 30, 2024
@RosscoG
Add run-time --max-msg command line argument
cb3d59a 
Resolves mity#33
- Defaults to TEST_MSG_MAXSIZE as normal.
- Adds new usage line in --help output
@RosscoG RosscoG linked a pull request Nov 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Feasible for new contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add max-msg run-time option RosscoG/acutest
2 participants
@mity @RosscoG