fixup! feat: add Library cappability on QML

Author: acolombier

res/qml/Library.qml

@@ -106,6 +106,8 @@ Item {
         LibraryComponent.TrackList {
             SplitView.fillHeight: true
 
+            clip: true
+
             model: root.sidebar.tracklist
         }
     }

res/qml/Library/Browser.qml

@@ -117,10 +117,10 @@ Rectangle {
                                     id: lineIcon
                                     anchors.left: parent.left
                                     anchors.verticalCenter: parent.verticalCenter
-                                    model: icon != null ? 1 : 0
+                                    model: !!icon ? 1 : 0
                                     Image {
-                                        visible: depth == 0
-                                        source: icon ? `images/library_${icon}.png` : null
+                                        visible: depth == 0 && icon
+                                        source: icon
                                         height: 25
                                         width: 25
                                     }

res/qml/Library/SourceTree.qml

@@ -9,7 +9,13 @@ Mixxx.LibrarySourceTree {
     component DefaultDelegate: LibraryComponent.Cell {
         id: cell
         readonly property var caps: capabilities
-        Drag.active: dragArea.drag.active
+        // FIXME: https://bugreports.qt.io/browse/QTBUG-111789
+        Binding on Drag.active {
+            value: dragArea.drag.active
+            // This delays the update until the even queue is cleared
+            // preventing any potential oscillations causing a loop
+            delayed: true
+        }
 
         LibraryComponent.Track {
             id: dragArea
@@ -21,7 +27,7 @@ Mixxx.LibrarySourceTree {
                     tableView.selectionModel.selectRow(row);
                     parent.dragImage.grabToImage((result) => {
                             parent.Drag.imageSource = result.url;
-                    });
+                        }, Qt.size(parent.dragImage.width, parent.dragImage.height));
                 }
             }
             onDoubleClicked: {
@@ -35,7 +41,7 @@ Mixxx.LibrarySourceTree {
             anchors.fill: parent
             anchors.leftMargin: 15
             font.pixelSize: 14
-            text: display
+            text: display ?? ""
             verticalAlignment: Text.AlignVCenter
             elide: Text.ElideRight
             color: Theme.textColor

src/qml/qmllibrarysource.cpp

@@ -23,7 +23,7 @@
 #include "track/track.h"
 
 AllTrackLibraryFeature::AllTrackLibraryFeature(Library* pLibrary, UserSettingsPointer pConfig)
-        : LibraryFeature(pLibrary, pConfig, QStringLiteral("tracks")),
+        : LibraryFeature(pLibrary, pConfig, QStringLiteral("")),
           m_pSidebarModel(make_parented<TreeItemModel>(this)),
           m_pLibraryTableModel(pLibrary->trackTableModel()) {
     m_pSidebarModel->setRootItem(TreeItem::newRoot(this));

src/qml/qmllibrarysourcetree.h

@@ -20,7 +20,8 @@ class QmlLibrarySourceTree : public QQuickItem {
     Q_OBJECT
     Q_INTERFACES(QQmlParserStatus)
     Q_PROPERTY(QQmlListProperty<QmlLibrarySource> sources READ sources)
-    Q_PROPERTY(QQmlListProperty<QmlLibraryTrackListColumn> defaultColumns READ defaultColumns FINAL)
+    Q_PROPERTY(QQmlListProperty<QmlLibraryTrackListColumn> defaultColumns READ
+                    defaultColumns CONSTANT)
     Q_CLASSINFO("DefaultProperty", "sources")
     QML_NAMED_ELEMENT(LibrarySourceTree)