Skip to content

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Sep 13, 2025

Fixes #15350

With Qt < 6.9 Alt press was reporte as Alt(modifier) + Qt::Key_Alt, now it's just the latter.

@Swiftb0y

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thank you. No regressions on your side too?

@ronso0
Copy link
Member Author

ronso0 commented Sep 13, 2025

Yup, still working.
getKeySeq has already been looking for key = Alt, so no issues to be expected 🥸

@ronso0
Copy link
Member Author

ronso0 commented Sep 13, 2025

maybe @JoergAtGithub @Eve00000 can test on Windows just to be sure?

@JoergAtGithub
Copy link
Member

I can only test with Qt6.8

@ronso0
Copy link
Member Author

ronso0 commented Sep 13, 2025

That would help to verify nothing is broken on Qt < 6.9

Though, we can also wrap it in #ifdef Qt >=6.9

@JoergAtGithub
Copy link
Member

I don't see a difference between 2.5 and this PR - both with Qt 6.5.3.
But I noticed that the menu toggle only works reliable after restarting Mixxx once. Immediately after setting the checkbox in the View menu, ALT just hides the menu, but can not show it. This happens in both cases.

@ronso0
Copy link
Member Author

ronso0 commented Sep 20, 2025

Okay. (not)
Can you please file an issue so we don't forget about it?

@JoergAtGithub
Copy link
Member

Can you please file an issue so we don't forget about it?

#15385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants