Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript support #52

Open
MarcusAndreasSvensson opened this issue Nov 15, 2023 · 2 comments · May be fixed by #116
Open

Typescript support #52

MarcusAndreasSvensson opened this issue Nov 15, 2023 · 2 comments · May be fixed by #116
Labels
enhancement New feature or request

Comments

@MarcusAndreasSvensson
Copy link

Hey,

I'd like to hear your stance on this topic.

Personally I think it's a great developer tool and a great aid when exposing the API to the end user.

I'd happily convert the existing code if you'd like me to.

@mkkellogg
Copy link
Owner

I've definitely thought about using it for this project, but I'm still not quite sure. Typescript makes more sense to me for larger projects and projects that have a lot of contributors so it seems a little overkill for something like this. Let me stew on this for a while longer :)

@guyettinger
Copy link

guyettinger commented Nov 23, 2023

I did a proof-of-concept port to typescript a while back (not as clean as it could be). You can see it at here:
gle-gs3d.

It's definitely difficult to maintain a port while the library is still under heavy development.

If you just want to provide support for typescript consumers, you can generate typescript declarations during the build process. I ended up using a fork to do just that, which you can see here:
gle-gaussian-splat-3d

The pertinent bits are in the rollup.config.js where you can use rollup-plugin-dts to generate the declarations.

Wonderful library by the way, I've been using it in my React Three Fiber / Cesium gle-scene-components project and it works exceptionally well!

Here's an example.

2023-11-22_20-03-25

@mkkellogg mkkellogg added the enhancement New feature or request label Jan 17, 2024
@sxxov sxxov linked a pull request Feb 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants