Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bashrc modification can cause warnings #41

Open
hlabrand opened this issue Jul 10, 2018 · 2 comments
Open

Bashrc modification can cause warnings #41

hlabrand opened this issue Jul 10, 2018 · 2 comments
Assignees
Labels

Comments

@hlabrand
Copy link

hlabrand commented Jul 10, 2018

Hello,

I've used electron-forge on Linux, which uses tabtab, and I ran into a small bug that seems to be cause by tabtab : the program adds something to ~/.bashrc that looks like

# tabtab source for electron-forge package
# uninstall by removing these lines or running `tabtab uninstall electron-forge`
[ -f /home/user/<etc-etc>/node_modules/tabtab/.completions/electron-forge.bash ] && . /home/user/<etc-etc>/node_modules/tabtab/.completions/electron-forge.bash

where the "etc-etc" is the path I installed it to. If that path contains spaces, those spaces are not escaped (" " is written instead of "\ ") which triggers an error ("bash [ too many arguments" every time you open a terminal) and means the command that is added is not run properly.
The fix is (hopefully) easy; the spaces need to be escaped.
Thanks!

@mklabs mklabs self-assigned this Jul 14, 2018
@mklabs
Copy link
Owner

mklabs commented Jul 14, 2018

Hi @hlabrand Thanks for letting me know. The fix is indeed (hopefully) easy. I'll take a look asap.

@mklabs mklabs added the bug label Jul 14, 2018
@antoniovs1029
Copy link

I've just had exactly the same issue. Fortunately, it's fixed by changing manually the empty spaces in the path for "\ " as @hlabrand had explained. Thanks for pointing to that solution! Never imagined that I was having that problem because I'd been playing around with electron-forge lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants