Skip to content

With unittest, skipping a test should actually skip instead of asserting False #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cnelsonsic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

With unittest, skipping a test should actually skip instead of asserting False #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pythoscope/generator/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def equal_assertion(self, expected, actual):
def raises_assertion(self, exception, call):
return combine(exception, call, "self.assertRaises(%s, %s)")
def skip_test(self):
return CodeString("assert False # TODO: implement your test here")
return CodeString("self.skipTest('# TODO: implement your test here.')")

class NoseTemplate(Template):
def equal_assertion(self, expected, actual):
Expand Down