Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe resizing? #46

Open
joeyklee opened this issue May 15, 2019 · 5 comments
Open

iframe resizing? #46

joeyklee opened this issue May 15, 2019 · 5 comments
Labels
good first issue Good for newcomers

Comments

@joeyklee
Copy link
Contributor

The iframes are a decent solution for handling adding our examples, but there are some usability issues for examples that require some kind of interaction.

Currently the fixed height of the iframe box makes it such that any interface buttons for the examples disappear. This is maybe more of an issue with our examples and the layout, but just wanted to flag this for discussion.

e.g - it is hard to add "rock, paper, scissors" to the KNN example without seeing the video

Screen Shot 2019-05-15 at 15 02 46

@wenqili
Copy link
Member

wenqili commented May 15, 2019

This is a forever issue of iframe lol

@wenqili
Copy link
Member

wenqili commented May 16, 2019

I tried to resize it but failed for now. The ml5 site needs to have access to the document of iframe to get the scrollHeight, which raises CORS issue. Damn it.

@shiffman
Copy link
Member

What about a manually set YAML property on a page level? It can default to something but we override if necessary?

@bomanimc
Copy link
Member

bomanimc commented Mar 7, 2021

We no longer include iframes in the docs, so I'm closing this issue for now!

@bomanimc bomanimc closed this as completed Mar 7, 2021
@bomanimc
Copy link
Member

bomanimc commented Mar 7, 2021

Correction: we do still have iframes for YouTube videos that could use some better sizing logic! Reopening and adding this as good first issue. I can return here and share some suggestions about what we can do to fix this.

@bomanimc bomanimc reopened this Mar 7, 2021
@bomanimc bomanimc added the good first issue Good for newcomers label Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants