-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iframe resizing? #46
Comments
This is a forever issue of iframe lol |
I tried to resize it but failed for now. The ml5 site needs to have access to the document of iframe to get the scrollHeight, which raises CORS issue. Damn it. |
What about a manually set YAML property on a page level? It can default to something but we override if necessary? |
We no longer include iframes in the docs, so I'm closing this issue for now! |
Correction: we do still have iframes for YouTube videos that could use some better sizing logic! Reopening and adding this as good first issue. I can return here and share some suggestions about what we can do to fix this. |
The iframes are a decent solution for handling adding our examples, but there are some usability issues for examples that require some kind of interaction.
Currently the fixed height of the iframe box makes it such that any interface buttons for the examples disappear. This is maybe more of an issue with our examples and the layout, but just wanted to flag this for discussion.
e.g - it is hard to add "rock, paper, scissors" to the KNN example without seeing the video
The text was updated successfully, but these errors were encountered: