-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlazePose documentation of z coordinates #181
Comments
I just ran [
{
"score": 0.995323121547699,
"keypoints": [
{
"x": 245.63711038340324,
"y": 294.79695594356946,
"z": -689535.245693554,
"score": 0.9987707333798664,
"name": "nose"
},
{
"x": 270.6604500325918,
"y": 252.8618703269841,
"z": -639394.1690627289,
"score": 0.9983254733819559,
"name": "left_eye_inner"
},
// ...
],
"keypoints3D": [
{
"x": 0.01237955486137293,
"y": -0.587451014244643,
"z": -0.2591571422454245,
"score": 0.9982515152476616,
"name": "nose"
},
{
"x": 0.026530376499100554,
"y": -0.6236724986839615,
"z": -0.24141936558530744,
"score": 0.9973494677709942,
"name": "left_eye_inner"
},
// ...
]
}
] Looks like the I think the named keypoints just copy the |
Thank you for looking into this @ziyuan-linn! Let's do the following:
I was about to say let's add only the nose: {
x: 332.6024622758805,
y: 265.78330263473146,
confidence: 0.9993924452777454,
keypoint3D: {
x: 0.05988978072436527,
y: -0.5489126977664187,
z: -0.26418375968933105
}
} Or is this overdoing it and making it super complicated? @MOQN I'd be curious for your thoughts? On another note, I'm trying to figure out why the tfjs docs list 4 extra points for
|
@shiffman I also have no idea what those keypoints are. The tfjs documentation can sometimes be puzzling. The I will reply with my thoughts about the API in the ml5-next-gen thread. |
Actually just looking at the model card I think the 2d
However, a value like |
Thank you for all of these findings and thoughtful discussion. I completely agree with removing the |
@shiffman, I believe it's a great suggestion. Very intuitive! (Edit: I wrote it too quicky suggesting nose: {
x: 332.6024622758805,
y: 265.78330263473146,
confidence: 0.9993924452777454,
position: {
x: 0.05988978072436527,
y: -0.5489126977664187,
z: -0.26418375968933105
}
} or nose: {
x: 332.6024622758805,
y: 265.78330263473146,
confidence: 0.9993924452777454,
x3D: 0.05988978072436527,
y3D: -0.5489126977664187,
z3D: -0.26418375968933105
}
[
{
box: { width, height, xMax, xMin, yMax, yMin },
id: 1,
keypoints: [{ x, y, confidence, name }, ...],
keypoints3D: [{ x, y, z, confidence, name }, ...],
left_ankle: { x, y, z, confidence },
...
confidence: 0.28,
},
...
]; |
These are great suggestions! I'd love to hear everyone's feedback during the meeting today! |
Hello web team! Just noting this has now been incorporated so we can update the documentation! See ml5js/ml5-next-gen#215 |
@shiffman @MOQN @ziyuan-linn Hi team, @leey611 and I are currently working on the documentations to address this issue. While the named keypoints update is functioning well, we’ve discovered that the |
Ah i just checked and you are right! Let me make a quick fix for this and we can do a 1.1.1 release! |
Hi everyone! I'm working on a video tutorial about
BodyPose
in ml5.js 1.0. I discovered in the making of the video some improvements I think we could make to the documentation of how the 3D coordinates work with BlazePose.In the tfjs-models documentation the units for
keypoints3D
are explained as follows:We should probably include a simplified version of this in our documentation here:
I was also confused to find that the 2D keypoints array (as described in our docs) also includes a
z
value. I don't believe this is part of the originalBlazePose
data. It looks like this is the code where it is being added but the units appear to be different. @ziyuan-linn, do you know offhand what is happening here? Is there some code I'm missing which is trying to change the real world "meters" range to pixel units?This is what I see in the console:
keypoints
:keypoints3D
:And now under the
nose
property:(Interesting to note that the confidence score is different for
keypoints3D
!)The text was updated successfully, but these errors were encountered: