Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ml5 library version in all pages #97

Open
QuinnHe opened this issue Jun 18, 2024 · 6 comments
Open

Update ml5 library version in all pages #97

QuinnHe opened this issue Jun 18, 2024 · 6 comments

Comments

@QuinnHe
Copy link
Collaborator

QuinnHe commented Jun 18, 2024

currently, use @Alpha tag

@alanvww
Copy link
Member

alanvww commented Jun 19, 2024

I made this change in PR #99 . Looks like only readme.md and develop-contributor-notes.md are not using ml5@alpha in the links.

@QuinnHe
Copy link
Collaborator Author

QuinnHe commented Jun 21, 2024

I made this change in PR #99 . Looks like only readme.md and develop-contributor-notes.md are not using ml5@alpha in the links.

Thanks @alanvww ! Maybe we will switch to an exact version number like 1.0.0. @ziyuan-linn here to get more suggestions. cc @MOQN

@ziyuan-linn
Copy link
Member

I think we will implement measures to follow semantic versioning after the 1.0 release? @shiffman @sharellb If so, ml5@1 should be fine, bumping to the latest non-breaking update. I believe this is what @shiffman has in the Nature of Code book too.

[email protected] definitely works though. My only concern is that it won't update if we release a bug fix.

@QuinnHe
Copy link
Collaborator Author

QuinnHe commented Jun 21, 2024

ml5@1

Thanks Peter @ziyuan-linn ! Okie, let's swicth to ml5@1 for all pages then. cc @alanvww Alan, if you have time, feel free to do it, if not, I can work on it after other stuff 🙏

@alanvww
Copy link
Member

alanvww commented Jun 21, 2024

@QuinnHe @ziyuan-linn np, I am going to change that now

@QuinnHe
Copy link
Collaborator Author

QuinnHe commented Jun 22, 2024

#118 merged, and all versions in Step-by-step guide are updated.
Pending: update all iframe source code to ml5@1 after soft launch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants