Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.10 release #177

Closed
Budek opened this issue Dec 28, 2016 · 9 comments
Closed

Django 1.10 release #177

Budek opened this issue Dec 28, 2016 · 9 comments

Comments

@Budek
Copy link

Budek commented Dec 28, 2016

(...)lib/python2.7/site-packages/selectable/forms/fields.py:27: RemovedInDjango110Warning: BaseAutoCompleteField._has_changed method should be renamed has_changed.
class BaseAutoCompleteField(forms.Field):

Can you create new version (0.10?) and send it to pypi?

@hugorodgerbrown
Copy link

+1 for this.

@raphaelmerx
Copy link
Contributor

@mlavin any idea when a Django 1.10 compatible version will be pushed to pypi? The current master branch is compatible with 1.10.

@mlavin
Copy link
Owner

mlavin commented Feb 24, 2017

The test suite passes but there are outstanding issues on the client side/admin which I haven't had time to address (#155, #167, #179, #183). It just isn't a priority for me ☹️

@raphaelmerx
Copy link
Contributor

raphaelmerx commented Feb 25, 2017

I looked into #179 and couldn't reproduce. Concerning the other issues you're linking to, they don't seem specific to the master branch or to Django 1.10. Why would issuing a new minor version impact these issues?

@raphaelmerx
Copy link
Contributor

#179 is fixed now. That was the only issue specific to Django 1.10. Would you consider issuing a new release?

@mlavin
Copy link
Owner

mlavin commented Apr 9, 2017

Thank you for your effort to track down and resolve these issues. I've opened #186 to track the failures/remaining issues for 1.10/1.11 and I'm going to be resolving them in the next week or so.

@mlavin
Copy link
Owner

mlavin commented Apr 14, 2017

v1.0.0 compatible with 1.10 is up on PyPi: https://pypi.python.org/pypi/django-selectable/1.0.0

@mlavin mlavin closed this as completed Apr 14, 2017
@raphaelmerx
Copy link
Contributor

Thank you @mlavin for the new release, really appreciate it!

@mlavin
Copy link
Owner

mlavin commented Apr 17, 2017

This release wouldn't have happened without your effort so thank you @raphaelmerx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants