Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1244 #1250

Closed
wants to merge 5 commits into from
Closed

Fix #1244 #1250

wants to merge 5 commits into from

Conversation

arjunsuresh
Copy link
Contributor

Fix "--branch" for cm pull repo

Fix "--branch" for cm pull repo
@arjunsuresh arjunsuresh requested a review from a team as a code owner May 7, 2024 11:01
Copy link

github-actions bot commented May 7, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@gfursin gfursin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think "&&" will not work on Windows ... It's a core functionality and we should make sure that it works on all platforms.

@arjunsuresh
Copy link
Contributor Author

I think it works on new shells on Windows. This feature is currently broken in CM. So needs to be merged.

@arjunsuresh
Copy link
Contributor Author

This change works fine on Windows as tested by github actions here. But since these changes are part of that linked PR, I'm closing this PR.

@arjunsuresh arjunsuresh closed this Jun 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants