Skip to content

Commit bf8fa6c

Browse files
authored
Merge pull request #62 from arjunsuresh/mlperf-inference
Fix for setup.py
2 parents cbc984e + bd1732d commit bf8fa6c

File tree

6 files changed

+26
-13
lines changed

6 files changed

+26
-13
lines changed

Diff for: .github/workflows/test-cm4mlops-wheel.yml

+6-2
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,13 @@ on:
1010
jobs:
1111
build:
1212
strategy:
13+
fail-fast: false
1314
matrix:
1415
os: [ubuntu-latest, ubuntu-20.04]
15-
python-version: ['3.8', '3.12']
16+
python-version: ['3.8', '3.11', '3.12']
17+
exclude:
18+
- os: ubuntu-latest
19+
python-version: "3.8"
1620

1721
runs-on: ${{ matrix.os }}
1822

@@ -36,4 +40,4 @@ jobs:
3640
run: |
3741
python3 -m venv cm
3842
source cm/bin/activate
39-
python3 -m pip install .
43+
python3 -m pip install . -v

Diff for: .github/workflows/test-mlperf-inference-resnet50.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ jobs:
2626
exclude:
2727
- backend: tf
2828
implementation: cpp
29-
- os: windows-latest
29+
- os: macos-latest
3030
backend: tf
31-
- os: windows-latest
32-
python-version: "3.9"
3331
- os: macos-latest
32+
python-version: "3.9"
33+
- os: windows-latest
3434

3535
steps:
3636
- uses: actions/checkout@v3

Diff for: pyproject.toml

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[build-system]
2+
requires = ["setuptools>=60", "wheel", "cmind @ git+https://[email protected]/mlcommons/ck.git@a4c6a7b477af5f1e7099c55f5468a47854adaa6c#egg=cmind&subdirectory=cm"]

Diff for: script/build-dockerfile/dockerinfo.json

+4-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"package-manager-update-cmd": "apt-get update -y",
2626
"package-manager-get-cmd": "apt-get install -y",
2727
"packages": [
28-
"python3", "python3-pip", "git", "sudo", "wget"
28+
"python3", "python3-pip", "git", "sudo", "wget", "python3-venv"
2929
],
3030
"versions": {
3131
"18.04": {
@@ -39,6 +39,9 @@
3939
},
4040
"23.04": {
4141
"FROM": "ubuntu:23.04"
42+
},
43+
"24.04": {
44+
"FROM": "ubuntu:24.04"
4245
}
4346
}
4447
},

Diff for: script/get-sys-utils-cm/run-ubuntu.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ ${CM_SUDO} ${CM_APT_TOOL} update && \
5353
libncurses5 \
5454
libjpeg9-dev \
5555
unzip \
56-
libgl1-mesa-glx \
56+
libgl1 \
5757
zlib1g-dev
5858

5959
# Install Python deps though preference is to install them

Diff for: setup.py

+10-6
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@ class CustomInstallCommand(install):
1212
def run(self):
1313
self.get_sys_platform()
1414
self.install_system_packages()
15-
packages = [ "cmind @ git+https://[email protected]/mlcommons/ck.git@a4c6a7b477af5f1e7099c55f5468a47854adaa6c#egg=cmind-2.3.1.1&subdirectory=cm", "giturlparse", "requests", "pyyaml", "setuptools" ]
16-
subprocess.check_call(
17-
[sys.executable, '-m', 'pip', 'install'] + packages
18-
)
15+
1916
# Call the standard run method
2017
install.run(self)
2118

@@ -36,7 +33,7 @@ def install_system_packages(self):
3633
if not curl_status:
3734
packages.append("curl")
3835

39-
name='virtualenv'
36+
name='venv'
4037

4138
if name in sys.modules:
4239
pass #nothing needed
@@ -113,7 +110,14 @@ def get_sys_platform(self):
113110
name='cm4mlops',
114111
version='0.1',
115112
packages=[],
116-
install_requires=["wheel"],
113+
install_requires=[
114+
"setuptools>=60",
115+
"wheel",
116+
"cmind",
117+
"giturlparse",
118+
"requests",
119+
"pyyaml"
120+
],
117121
cmdclass={
118122
'install': CustomInstallCommand,
119123
},

0 commit comments

Comments
 (0)