-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mlc logger in scripts instead of print statements #165
Comments
Fix mlcommons#165, Replacement in the initial three files
@arjunsuresh, do we need to similarly modify all the scripts present inside the script folder individually to replace the print statements with the usage of logger? |
@sujik18 That's correct but a small change is needed. If we initialise
and then we can do
which uses the global logger. |
print("") @arjunsuresh if there are print statements which might be useful for both user and debugging purpose like the above, in such case is it better to implement both by initializing these messages in an array and then executing using a loop to implement both print and logger statements. info_messages = [ for message in info_messages: Or else, is it the case that we have to strictly replace all the print statements with logger in the scripts and have to remove the print statements entirely? |
@sujik18 These messages are in custom python files right? I think we need not change them to logger functions. We only need to change them in |
* Better naming for github action runs Fix for #134 * Use mlc logger in scripts instead of print statements 1.0 Fix #165, Replacement in the initial three files * Update test-mlperf-inference-rgat.yml test name update Co-authored-by: Arjun Suresh <[email protected]>
We now have a global logger from MLC being used in Script automation. We need to modify the individual scripts also to use this logger instead of print statements.
The text was updated successfully, but these errors were encountered: