Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean the boolean usage in MLCFlow #177

Open
arjunsuresh opened this issue Feb 3, 2025 · 0 comments
Open

Clean the boolean usage in MLCFlow #177

arjunsuresh opened this issue Feb 3, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@arjunsuresh
Copy link
Collaborator

We can now replace comparisons like

env.get('MLC_SAVE_CONSOLE_LOG', True)).lower() not in ["no", "false", "0"]:

with

not is_false(env.get('MLC_SAVE_CONSOLE_LOG', True)):

as we have the functions is_false and is_true in the utils.py. It'll be good to clean all such usages in customize.py files.
@arjunsuresh arjunsuresh added enhancement New feature or request good first issue Good for newcomers labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
MLPerf Automation
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arjunsuresh