Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase mistral backoff #848

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Increase mistral backoff #848

merged 2 commits into from
Feb 7, 2025

Conversation

bkorycki
Copy link
Contributor

@bkorycki bkorycki commented Feb 7, 2025

This results in 0 rate limit exceptions on my machine on a test of 1200 samples.

@bkorycki bkorycki requested a review from a team as a code owner February 7, 2025 01:26
@bkorycki bkorycki temporarily deployed to Scheduled Testing February 7, 2025 01:26 — with GitHub Actions Inactive
@bkorycki bkorycki temporarily deployed to Scheduled Testing February 7, 2025 01:26 — with GitHub Actions Inactive
@bkorycki bkorycki temporarily deployed to Scheduled Testing February 7, 2025 01:26 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

wpietri
wpietri approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@wpietri wpietri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe once this is merged, try running a full benchmark through the job manager just to make sure it works with a full run in prod?

rogthefrog
rogthefrog approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@rogthefrog rogthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tweaking these.

@bkorycki
Copy link
Contributor Author

bkorycki commented Feb 7, 2025

@wpietri Sounds good.

@bkorycki bkorycki merged commit a2f2af4 into main Feb 7, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wpietri wpietri wpietri approved these changes

@rogthefrog rogthefrog rogthefrog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkorycki @wpietri @rogthefrog