From 7b0c824846c10e2d93c44f699665c4e2000a821f Mon Sep 17 00:00:00 2001
From: mleem97 <52848568+mleem97@users.noreply.github.com>
Date: Fri, 31 Jul 2026 23:53:07 +0000
Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20[HIGH]=20Fi?=
 =?UTF-8?q?x=20path=20traversal=20in=20CustomEmployeeManager=20SetPortrait?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/API/CustomEmployeeManager.cs | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/API/CustomEmployeeManager.cs b/src/API/CustomEmployeeManager.cs
index 9b4512b6..ac2f0111 100644
--- a/src/API/CustomEmployeeManager.cs
+++ b/src/API/CustomEmployeeManager.cs
@@ -891,10 +891,19 @@ private static void SetPortrait(Transform card, string employeeId)
 
             string assetsDir = Path.Combine(MelonEnvironment.UserDataDirectory, "ModAssets");
             string? imagePath = null;
-            foreach (var ext in new[] { ".jpg", ".png" })
+
+            // Validate employeeId to prevent path traversal
+            if (employeeId.IndexOfAny(Path.GetInvalidFileNameChars()) < 0 && !employeeId.Contains(".."))
+            {
+                foreach (var ext in new[] { ".jpg", ".png" })
+                {
+                    string candidate = Path.Combine(assetsDir, employeeId + ext);
+                    if (File.Exists(candidate)) { imagePath = candidate; break; }
+                }
+            }
+            else
             {
-                string candidate = Path.Combine(assetsDir, employeeId + ext);
-                if (File.Exists(candidate)) { imagePath = candidate; break; }
+                CrashLog.Log($"[Security] CustomEmployee: Invalid characters in employeeId={employeeId} for portrait");
             }
 
             if (imagePath != null)