Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially incorrect order of operations and confusing logic #14

Open
phzwart opened this issue Mar 11, 2024 · 1 comment
Open

Potentially incorrect order of operations and confusing logic #14

phzwart opened this issue Mar 11, 2024 · 1 comment

Comments

@phzwart
Copy link
Collaborator

phzwart commented Mar 11, 2024

def segment(net, device, inference_loader, qlty_object, tiled_client):

I think it is better to split this function into separate chunks:

  1. one overall function that get a single frame from tiled
  2. ship the frame (or frames) to the segment function. in the segment function we run qlty internally, segment stuff and return back in image in the right shape.
  3. push results back via tiled

I will write step 2 right now

@TibbersHao
Copy link
Member

Yes @phzwart with the latest PR #18 the previous segment function has been replaced with the new function which takes a single frame and run qlty internally. Writing back to tiled is one line of code so it does not hurt too much to have part 3 with 2 to my opinion.

Please let me know if you have additional concerns for this issue, and I am happy to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants