-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FocusSearch doesn't handle discrete vector parameters #201
Comments
Addendum: this is a bug anyway since |
also general focussearch bugfixes
As commented in PR #202, infillOptFocus cannot, in principle, handle parameters that have requirements depending on discrete vector parameters. One would need to either adapt something in ParamHelpers or automatically rewrite the requirements and decompose vector params into scalar params. This is a bit tricky, but I've done something similar here with the help of this function. |
@berndbischl Please review |
@berndbischl: ping |
also general focussearch bugfixes
also general focussearch bugfixes
In particular, I reliably get an error here when I have a discrete vector parameter, since
val
is a list andsetdiff(val.names, val)
can makeval.names
empty even when it waslength(par$values) > 1L
before.Should I, in general, assume that mlrMBO wasn't designed to handle vector parameters and give up right now, or is this worth a fix?
The text was updated successfully, but these errors were encountered: