Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyOpenGL dependency version #224

Open
cosw0t opened this issue Apr 27, 2022 · 9 comments
Open

PyOpenGL dependency version #224

cosw0t opened this issue Apr 27, 2022 · 9 comments

Comments

@cosw0t
Copy link
Contributor

cosw0t commented Apr 27, 2022

Hi! is there any reason why there is a hard dependency on pyopengl==3.1.0?

pyopengl is now at version 3.1.6, with lots of bug fixes and no API changes. Would it make sense to remove the hard version requirement?

thanks!

@cwiede
Copy link

cwiede commented May 2, 2022

+1 just stumbled upon the same step stone

@mmatl
Copy link
Owner

mmatl commented May 3, 2022

Add a PR to correct the hard dep and I'll patch!

@cosw0t
Copy link
Contributor Author

cosw0t commented May 3, 2022

Thanks @mmatl, the PR is here! #226

I have just noticed that master already has a commit that gets around the issue with a "PyOpengl~=3.1.0".
I hadn't noticed it because it's not in pip yet. I guess it's up to you to chose which on you prefer now :) fell free to close my PR if you wish.

@cwiede
Copy link

cwiede commented May 3, 2022

Oh just started to do it, but then I realized that the patch seems to be already in place: 7c613e8. I'd have used a ">=3.1.0,<4.0.0" instead of the "~=3.1.0" dependency, but anyways the existing patch patch seems to correct the issue.

However, the last release on pypi doesn't incorporate it.

@michele-arrival you have overtaken my response :)

@cosw0t
Copy link
Contributor Author

cosw0t commented May 3, 2022

you have a point though, ~=3.1.0 will not update to 3.2.x, whereas ">=3.1.0,<4.0.0" will. I'm not sure what's best. again i 'm happy to leave that decision to matt

@nlsdvl
Copy link

nlsdvl commented Oct 19, 2022

+1 running into this as well.
Anyways ... great job on this library.

@orperel
Copy link

orperel commented Jan 30, 2023

Hi! Any news for bumping the PyOpenGL's min version for the wheels?
I'd love to test this with kaolin-wisp, but the downgraded gl version requires us to turn off features like anisotropic filtering.

Love the lightweight design btw, kudos on a great library!

@MaxGyver83
Copy link

I ran into this as well. A new tag/release would be nice!

@traversaro
Copy link

traversaro commented May 28, 2024

Just in case somebody stumbles in this issue, we had the same problem for urdfpy : mmatl/urdfpy#31 . As urdfpy depends on pyrender, for our friendly fork we also friendly forked pyrender in https://github.com/fishbotics/pyribbit . pyribbit is just pyrender renamed (to avoid any naming clash) and with the pyopengl pinning resolved, and available on both pip (pypi) and conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants