Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the use of core_1D.jl and replace with multiple dispatch version #38

Open
mochell opened this issue Feb 1, 2025 · 0 comments
Open

Remove the use of core_1D.jl and replace with multiple dispatch version #38

mochell opened this issue Feb 1, 2025 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mochell
Copy link
Owner

mochell commented Feb 1, 2025

Currently PiCLES throughs error when complied because functions are loaded from core_1D and core_2D.

  • remove all 1D specific files and create 1D modeling through multiple dispatch
  • update tests that use 1D versions
@mochell mochell added bug Something isn't working good first issue Good for newcomers labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/38-remove-the-use-of-core_1djl-and-replace-with-multiple-dispatch-version mochell/PiCLES
1 participant
@mochell