We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently we have
Principia/numerics/elliptic_integrals.cpp
Lines 116 to 120 in 90904e3
Principia/astronomy/orbital_elements_body.hpp
Line 461 in 90904e3
Principia/astronomy/orbit_ground_track_body.hpp
Line 94 in 90904e3
Principia/physics/kepler_orbit_body.hpp
Lines 166 to 169 in 90904e3
Principia/numerics/double_precision_body.hpp
Lines 309 to 316 in 90904e3
None of those are correctly rounded, and we keep writing more of that kind of thing (most recently in #3761 (comment)), there reducing to ]-π, π[.
We should centralize the angle reduction functions somewhere in numerics (and make them correctly rounded someday, see #1760).
The text was updated successfully, but these errors were encountered:
A better implementation would be part of #1760.
Sorry, something went wrong.
No branches or pull requests
Currently we have
Principia/numerics/elliptic_integrals.cpp
Lines 116 to 120 in 90904e3
Principia/astronomy/orbital_elements_body.hpp
Line 461 in 90904e3
Principia/astronomy/orbit_ground_track_body.hpp
Line 94 in 90904e3
some of them with preconditions,
Principia/physics/kepler_orbit_body.hpp
Lines 166 to 169 in 90904e3
one slightly better one seemingly used only in tests,
Principia/numerics/double_precision_body.hpp
Lines 309 to 316 in 90904e3
None of those are correctly rounded, and we keep writing more of that kind of thing (most recently in #3761 (comment)), there reducing to ]-π, π[.
We should centralize the angle reduction functions somewhere in numerics (and make them correctly rounded someday, see #1760).
The text was updated successfully, but these errors were encountered: