Skip to content

Bloated MIR remains for Result functions #4168

@AlexanderPortland

Description

@AlexanderPortland

Proposed change:
Maybe some strategy for stubbing all string formatting could be helpful for bloat and not affect our correctness? At the very least finding a way to stub unwrap_failed() specifically would help these instances.

Motivation:
Result::unwrap() and Result::expect() seem to have unique call trees going through the core::result::unwrap_failed() that still cause significant MIR bloat even with panic stubbing. This seems to be due to the way the panic!() macro is called, causing it to expand into calls to display and debug format functions as well as the actual call to core::panic() that is eventually stubbed.

Metadata

Metadata

Labels

Z-Kani CompilerIssues that require some changes to the compiler[E] PerformanceTrack performance improvement (Time / Memory / CPU)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions