Skip to content

fix: bump SDK to 1.26.0, fix tools_call scenario #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcarleton merged 3 commits into from
Feb 5, 2026
+46 −26
Merged

fix: bump SDK to 1.26.0, fix tools_call scenario #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f7805c
fix: bump SDK to 1.26.0, add session management to tools_call scenario
pcarleton Feb 5, 2026
d591488
fix: return 404 for invalid session IDs in tools_call POST handler
pcarleton Feb 5, 2026
2f87479
refactor: keep tools_call stateless, create fresh server per request
pcarleton Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 37 additions & 23 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"vitest": "^4.0.16"
},
"dependencies": {
"@modelcontextprotocol/sdk": "^1.25.2",
"@modelcontextprotocol/sdk": "^1.26.0",
"commander": "^14.0.2",
"eventsource-parser": "^3.0.6",
"express": "^5.1.0",
Expand Down
10 changes: 8 additions & 2 deletions src/scenarios/client/tools_call.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import express, { Request, Response } from 'express';
import { ScenarioUrls } from '../../types';
import { createRequestLogger } from '../request-logger';

function createServer(checks: ConformanceCheck[]): express.Application {
function createMcpServer(checks: ConformanceCheck[]): Server {
const server = new Server(
{
name: 'add-numbers-server',
Expand Down Expand Up @@ -84,6 +84,10 @@ function createServer(checks: ConformanceCheck[]): express.Application {
throw new Error(`Unknown tool: ${request.params.name}`);
});

return server;
}

function createServerApp(checks: ConformanceCheck[]): express.Application {
const app = express();
app.use(express.json());

Expand All @@ -96,6 +100,8 @@ function createServer(checks: ConformanceCheck[]): express.Application {
);

app.post('/mcp', async (req: Request, res: Response) => {
// Stateless: create a fresh server and transport per request
const server = createMcpServer(checks);
const transport = new StreamableHTTPServerTransport({
sessionIdGenerator: undefined
});
Expand All @@ -116,7 +122,7 @@ export class ToolsCallScenario implements Scenario {

async start(): Promise<ScenarioUrls> {
this.checks = [];
this.app = createServer(this.checks);
this.app = createServerApp(this.checks);
this.httpServer = this.app.listen(0);
const port = this.httpServer.address().port;
return { serverUrl: `http://localhost:${port}/mcp` };
Expand Down
Loading