fix: Replace any types with proper window.location mocking in configUtils tests

Author: felixweinberger

client/src/utils/__tests__/configUtils.test.ts

@@ -8,6 +8,15 @@ import {
 import { DEFAULT_INSPECTOR_CONFIG } from "../../lib/constants";
 import { InspectorConfig } from "../../lib/configurationTypes";
 
+// Helper to mock window.location
+function mockWindowLocation(href: string) {
+  Object.defineProperty(window, "location", {
+    value: { ...window.location, href },
+    writable: true,
+    configurable: true,
+  });
+}
+
 describe("configUtils", () => {
   describe("getMCPProxyAuthToken", () => {
     test("returns token and default header name", () => {
@@ -83,26 +92,21 @@ describe("configUtils", () => {
       // Clear localStorage
       localStorage.clear();
       // Mock window.location
-      delete (window as any).location;
-      (window as any).location = {
-        ...originalLocation,
-        href: "http://localhost:6274",
-      };
+      mockWindowLocation("http://localhost:6274");
     });
 
     afterEach(() => {
-      (window as any).location = originalLocation;
+      mockWindowLocation(originalLocation.href);
     });
 
     test("returns transport type from URL query parameter", () => {
-      (window as any).location.href = "http://localhost:6274/?transport=sse";
+      mockWindowLocation("http://localhost:6274/?transport=sse");
       expect(getInitialTransportType()).toBe("sse");
 
-      (window as any).location.href =
-        "http://localhost:6274/?transport=streamable-http";
+      mockWindowLocation("http://localhost:6274/?transport=streamable-http");
       expect(getInitialTransportType()).toBe("streamable-http");
 
-      (window as any).location.href = "http://localhost:6274/?transport=stdio";
+      mockWindowLocation("http://localhost:6274/?transport=stdio");
       expect(getInitialTransportType()).toBe("stdio");
     });
 
@@ -117,14 +121,12 @@ describe("configUtils", () => {
 
     test("query parameter takes precedence over localStorage", () => {
       localStorage.setItem("lastTransportType", "sse");
-      (window as any).location.href =
-        "http://localhost:6274/?transport=streamable-http";
+      mockWindowLocation("http://localhost:6274/?transport=streamable-http");
       expect(getInitialTransportType()).toBe("streamable-http");
     });
 
     test("ignores invalid transport type from query param", () => {
-      (window as any).location.href =
-        "http://localhost:6274/?transport=invalid";
+      mockWindowLocation("http://localhost:6274/?transport=invalid");
       expect(getInitialTransportType()).toBe("stdio");
     });
   });
@@ -134,20 +136,17 @@ describe("configUtils", () => {
 
     beforeEach(() => {
       localStorage.clear();
-      delete (window as any).location;
-      (window as any).location = {
-        ...originalLocation,
-        href: "http://localhost:6274",
-      };
+      mockWindowLocation("http://localhost:6274");
     });
 
     afterEach(() => {
-      (window as any).location = originalLocation;
+      mockWindowLocation(originalLocation.href);
     });
 
     test("returns serverUrl from query parameter", () => {
-      (window as any).location.href =
-        "http://localhost:6274/?serverUrl=http://example.com/sse";
+      mockWindowLocation(
+        "http://localhost:6274/?serverUrl=http://example.com/sse",
+      );
       expect(getInitialSseUrl()).toBe("http://example.com/sse");
     });
 
@@ -162,15 +161,15 @@ describe("configUtils", () => {
 
     test("query parameter takes precedence over localStorage", () => {
       localStorage.setItem("lastSseUrl", "http://stored.com/sse");
-      (window as any).location.href =
-        "http://localhost:6274/?serverUrl=http://param.com/sse";
+      mockWindowLocation(
+        "http://localhost:6274/?serverUrl=http://param.com/sse",
+      );
       expect(getInitialSseUrl()).toBe("http://param.com/sse");
     });
 
     test("handles encoded URLs in query parameters", () => {
       const encodedUrl = encodeURIComponent("http://example.com/sse?token=123");
-      (window as any).location.href =
-        `http://localhost:6274/?serverUrl=${encodedUrl}`;
+      mockWindowLocation(`http://localhost:6274/?serverUrl=${encodedUrl}`);
       expect(getInitialSseUrl()).toBe("http://example.com/sse?token=123");
     });
   });
@@ -180,20 +179,15 @@ describe("configUtils", () => {
 
     beforeEach(() => {
       localStorage.clear();
-      delete (window as any).location;
-      (window as any).location = {
-        ...originalLocation,
-        href: "http://localhost:6274",
-      };
+      mockWindowLocation("http://localhost:6274");
     });
 
     afterEach(() => {
-      (window as any).location = originalLocation;
+      mockWindowLocation(originalLocation.href);
     });
 
     test("returns serverCommand from query parameter", () => {
-      (window as any).location.href =
-        "http://localhost:6274/?serverCommand=node";
+      mockWindowLocation("http://localhost:6274/?serverCommand=node");
       expect(getInitialCommand()).toBe("node");
     });
 
@@ -208,8 +202,7 @@ describe("configUtils", () => {
 
     test("handles encoded commands in query parameters", () => {
       const encodedCmd = encodeURIComponent("node server.js");
-      (window as any).location.href =
-        `http://localhost:6274/?serverCommand=${encodedCmd}`;
+      mockWindowLocation(`http://localhost:6274/?serverCommand=${encodedCmd}`);
       expect(getInitialCommand()).toBe("node server.js");
     });
   });
@@ -219,20 +212,15 @@ describe("configUtils", () => {
 
     beforeEach(() => {
       localStorage.clear();
-      delete (window as any).location;
-      (window as any).location = {
-        ...originalLocation,
-        href: "http://localhost:6274",
-      };
+      mockWindowLocation("http://localhost:6274");
     });
 
     afterEach(() => {
-      (window as any).location = originalLocation;
+      mockWindowLocation(originalLocation.href);
     });
 
     test("returns serverArgs from query parameter", () => {
-      (window as any).location.href =
-        "http://localhost:6274/?serverArgs=--debug";
+      mockWindowLocation("http://localhost:6274/?serverArgs=--debug");
       expect(getInitialArgs()).toBe("--debug");
     });
 
@@ -247,8 +235,7 @@ describe("configUtils", () => {
 
     test("handles encoded args in query parameters", () => {
       const encodedArgs = encodeURIComponent("--port 3000 --host 0.0.0.0");
-      (window as any).location.href =
-        `http://localhost:6274/?serverArgs=${encodedArgs}`;
+      mockWindowLocation(`http://localhost:6274/?serverArgs=${encodedArgs}`);
       expect(getInitialArgs()).toBe("--port 3000 --host 0.0.0.0");
     });
   });