-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring of the repository #90
Comments
I think this is a super nice opportunity. Please go ahead and prepare a PR - I will support the integration and I may also help with the CI part. |
Nice, I'll try to get approval and will then check back with you. |
Just a quick heads-up: Any news on this will not come before mid-September. |
- This closes #89 and possibly relates to #90. - The new manually triggered CI job uses the suggestions from #89 to find the minimum CMake version. - Wrong version of cmake required to compile the library #89 to find the minimum CMake version. - The minor adjustments in the CMakeLists.txt reduce the needed CMake version to 3.8 instead of 3.18 - The missing CoolProp include directories have also been fixed. - As pointed out in #85, we may want to bring back the subdirectory notation for GCC and friends, this is also included here.
Another heads-up: The application for open-sourcing the restructure is now in the process of approval. Unfortunately I cannot give a further time estimate but will of course report back as soon as I know more. |
Hi!
As my name suggests I'm working for ABB with this library.
In order to understand how to work with the library, I quite heavily restructured the repository and decomposed externalmedialib it into different sub-libraries that are all linked into externalmedialib.
My question is the following:
Would you possibly be interested in a PR containing the restructuring? I'll describe it in the following and would like some idea on how willing you would be to merge it/advice me on possible revisions such that you would then like to merge it, before I start the process of getting formal approval from my company for contributing the restructuring back to the project.
The pull request would in total contain the following:
)
5. Symbols are hidden by default and only those also exported under Windows are visible.
6. The outer usage would stay the same, apart from needing to clone the repository with
--recursive
because of the git submodule. Note that I don't have access to FluidProp, so can not test it.Advantages are in my opinion the following:
Disadvantages:
The text was updated successfully, but these errors were encountered: