Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to not regenerate types during hmr #3110

Open
2 tasks done
leanllg opened this issue Oct 23, 2024 · 7 comments
Open
2 tasks done

Add the ability to not regenerate types during hmr #3110

leanllg opened this issue Oct 23, 2024 · 7 comments

Comments

@leanllg
Copy link

leanllg commented Oct 23, 2024

Clear and concise description of the problem

Generate module federation types makes rsbuild hmr slow(from 0.4s to 4s). When I set disableHotTypesReload to true, it still regenerate types. And I find disableHotTypesReload option can't control this behavior. So it would be better to have an option to not generate types during hmr to improve hmr speed.

Suggested solution

Maybe stop regenerate types when provider set disableHotTypesReload to true or just add a new opition.

Alternative

No response

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@jbroma
Copy link
Contributor

jbroma commented Nov 13, 2024

This is still a valid issue,

Currently, the options in dev configuration don't seem to work as expected.

Correct me if I'm wrong, but I would expect that setting dev to false would ultimately turn off any sort of build performance impact after the initial build? Currently, with DTS enabled we're seeing slow downs of like 4x - 5x in HMR time.

Are there any plans to make DTS faster with things like web-infra-dev/rspack#8097 on the horizon?

@zmzlois
Copy link

zmzlois commented Nov 13, 2024

This is still a valid issue,

Currently, the options in dev configuration don't seem to work as expected.

Correct me if I'm wrong, but I would expect that setting dev to false would ultimately turn off any sort of build performance impact after the initial build? Currently, with DTS enabled we're seeing slow downs of like 4x - 5x in HMR time.

Are there any plans to make DTS faster with things like web-infra-dev/rspack#8097 on the horizon?

have you tried this? https://www.typescriptlang.org/tsconfig/#isolatedDeclarations

@jbroma
Copy link
Contributor

jbroma commented Nov 13, 2024

@zmzlois haven't tried isolatedDeclarations on their own but now that I think of it it might still give us a significant improvement 🤔

@ScriptedAlchemy
Copy link
Member

This is still a valid issue,

Currently, the options in dev configuration don't seem to work as expected.

Correct me if I'm wrong, but I would expect that setting dev to false would ultimately turn off any sort of build performance impact after the initial build? Currently, with DTS enabled we're seeing slow downs of like 4x - 5x in HMR time.

Are there any plans to make DTS faster with things like web-infra-dev/rspack#8097 on the horizon?

What if you set dts: false?

@jbroma
Copy link
Contributor

jbroma commented Nov 14, 2024

This is still a valid issue,
Currently, the options in dev configuration don't seem to work as expected.
Correct me if I'm wrong, but I would expect that setting dev to false would ultimately turn off any sort of build performance impact after the initial build? Currently, with DTS enabled we're seeing slow downs of like 4x - 5x in HMR time.
Are there any plans to make DTS faster with things like web-infra-dev/rspack#8097 on the horizon?

What if you set dts: false?

dts: false works but disables types completely (as expected)

@ScriptedAlchemy
Copy link
Member

Ahh you just want initial type gen. Then it to stop watching subsequent updates?

@ScriptedAlchemy
Copy link
Member

@jbroma try this: 0.0.0-next-20241114065146

Im wondering if i can change the plugin so that initial build uses compilation.emitAsset and HMR update builds just use fs.writeFileSync, so that the hook does not await type generation and just lazily writes the updated file back to disk whenever it completes. Thoughts?
This way it would always remain updated, but would be delayed in synchronizing with the others - in order to not block the bundler workflow. Only the initial compile would be blocking in order to ensure that type generation happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants