Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook-addon should support Storybook v8 #3217

Open
2 tasks done
nate-summercook opened this issue Nov 12, 2024 · 3 comments
Open
2 tasks done

storybook-addon should support Storybook v8 #3217

nate-summercook opened this issue Nov 12, 2024 · 3 comments

Comments

@nate-summercook
Copy link

Clear and concise description of the problem

The module federation addon for storybook currently only supports v7 of storybook. Please upgrade this very needed plugin for usage with v8 ❤️

Suggested solution

Follow the storybook addon migration guide here https://storybook.js.org/docs/8.5/addons/addon-migration-guide

Alternative

No response

Additional context

Our project is currently locked in with storybook v7 because we rely on module federation, facing some other issues with that version. It would be nice to have a storybook-addon for module federation that supports the latest storybook version (v8 has been out for months)

Validations

  • Read the Contributing Guidelines.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@ScriptedAlchemy
Copy link
Member

Do you have a repo that shows the error or problem with v8?

@nate-summercook
Copy link
Author

Not right now, no. It seems to work with v8, but there's a warning that it is not compatible:

WARN The following packages are incompatible with Storybook 8.4.2 as they depend on different major versions of Storybook packages:
WARN - @module-federation/[email protected]

@ScriptedAlchemy
Copy link
Member

Gotcha. Then it's probably fine. Maybe we just need to widen the peer dependency list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants