Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0: latest is broken in windows #68

Closed
husayt opened this issue Aug 29, 2024 · 6 comments
Closed

v1.0.0: latest is broken in windows #68

husayt opened this issue Aug 29, 2024 · 6 comments

Comments

@husayt
Copy link
Contributor

husayt commented Aug 29, 2024

Examples stopped working for me with latest changes (on windows with dev run):

I get both host and remote broken with this error

chunk-R27WTGMQ.js:21  Uncaught TypeError: factory is not a function
    at chunk-R27WTGMQ.js:21:29
    at async chunk-R27WTGMQ.js:27:1

error happens here:

 var exportModule = (
      /*mf top-level-await placeholder replacement mf*/
      res.then((factory) => factory())
    );

factory comes out as false, hence factory is not a function error

this is wider code of where error happens

// node_modules/__mf__virtual/__loadShare__react__$2__jsx__$3__dev__$3__runtime.js
var require_loadShare_react_2_jsx_3_dev_3_runtime = __commonJS({
  "node_modules/__mf__virtual/__loadShare__react__$2__jsx__$3__dev__$3__runtime.js"(exports, module) {
    var { loadShare } = require_index_cjs();
    var res = loadShare("react/jsx-dev-runtime", {
      customShareInfo: { shareConfig: {
        singleton: false,
        strictVersion: false,
        requiredVersion: "^18.3.1"
      } }
    });
    var exportModule = (
      /*mf top-level-await placeholder replacement mf*/
      res.then((factory) => factory())
    );
    module.exports = exportModule;
  }
});
@zhangHongEn
Copy link
Contributor

I rented a cloud service windows server, but I haven't configured it successfully yet

@zhangHongEn
Copy link
Contributor

Can try it first
server.watch.usePolling:true

@zhangHongEn
Copy link
Contributor

@husayt
Copy link
Contributor Author

husayt commented Aug 29, 2024

I tried that, but still the same.

zhangHongEn pushed a commit to zhangHongEn/vite that referenced this issue Aug 30, 2024
@zhangHongEn
Copy link
Contributor

vitejs/vite#8619
Found the problem, but not the solution yet

@gioboa gioboa changed the title latest is broken in windows v1.0.0: latest is broken in windows Aug 31, 2024
zhangHongEn pushed a commit to zhangHongEn/vite that referenced this issue Aug 31, 2024
zhangHongEn pushed a commit to zhangHongEn/vite that referenced this issue Aug 31, 2024
zhangHongEn pushed a commit to zhangHongEn/vite that referenced this issue Aug 31, 2024
zhangHongEn pushed a commit to zhangHongEn/vite that referenced this issue Aug 31, 2024
zhangHongEn pushed a commit to zhangHongEn/vite that referenced this issue Aug 31, 2024
@zhangHongEn zhangHongEn mentioned this issue Aug 31, 2024
gioboa pushed a commit that referenced this issue Aug 31, 2024
* fix: #68

* fix: #68

* fix: windows Multi-Pack

* Optimization: Reduce file writing

* Optimization: code format

* fix: support nx monorepo

---------

Co-authored-by: 张洪恩 <[email protected]>
@gioboa
Copy link
Collaborator

gioboa commented Aug 31, 2024

Closed by #71

@gioboa gioboa closed this as completed Aug 31, 2024
gioboa added a commit that referenced this issue Sep 15, 2024
* feat: new plugin configuration (#28)

* init ts (#29)

* fix: tsconfig

* fix: issues 2 3

* feat: rust demo build and preview

---------

Co-authored-by: 张洪恩 <[email protected]>

* feat: support runtime plugins (#30)

Co-authored-by: Sergey Melukov <[email protected]>

* fix: Ensure @module-federation/runtime singleton (#31)

* fix: Ensure @module-federation/runtime singleton

* fix: build preview

---------

Co-authored-by: 张洪恩 <[email protected]>

* feat: add packageManager

* fix: remoteEntry support hash; format dynamic es module (#35)

* 1.0.0-alpha-7c3ba59

* fix: remove default export (#37)

* fix: remove pkg-pr-new

* chore: add PR title check

* 1.0.0-alpha-ffc6e23

* fix: #36 and dynamic import (#38)

* fix: dynamic import

* fix: #36

* 1.0.0-alpha-54ad191

* 1.0.0-alpha-80b7215

* fix: #39 #44 #45 (#46)

* fix: pre-bunding

* feat: add pre-bunding subdependencies demo

* fix: exposes .

* fix: remotes support namespace

* 1.0.0-alpha-4a73cd4

* fix: windows remoteEntry error (#48)

Co-authored-by: 张洪恩 <[email protected]>

* feat: updated examples (#50)

* 1.0.0-alpha-def937d

* fix updated examples (#51)

* fix: #47 (#53)

* 1.0.0-alpha-10e1f83

* improved  examples with MUI and etc (#55)

* fix: #56 #41 (#58)

* 1.0.0-alpha-6cae9ab

* mfruntime update and new examples (#62)

* fix: #61 (#63)

Co-authored-by: 张洪恩 <[email protected]>

* 1.0.0-alpha-51eeeb6

* feat: shared-slash (#67)

* feat: shared slash

* feat: shared slash

* feat: preview examples

* feat: remove an-empty-js-file

* fix: remove console

* optimization: reduce dev mode page reload

* Optimize code and comments

* fix: 64

* fix: only slash

---------

Co-authored-by: 张洪恩 <[email protected]>

* 1.0.0-alpha-f87d7d3

* fix: nx #40 (#69)

* 1.0.0-alpha-661e052

* fix: #68 (#71)

* fix: #68

* fix: #68

* fix: windows Multi-Pack

* Optimization: Reduce file writing

* Optimization: code format

* fix: support nx monorepo

---------

Co-authored-by: 张洪恩 <[email protected]>

* 1.0.0-alpha-1aa30c0

* fix: monorepo (#72)

Co-authored-by: 张洪恩 <[email protected]>

* feat: add Nuxt example (#75)

* Add Nuxt host example

* Gitignore generated .__mf__win folder

---------

Co-authored-by: David Sellén <[email protected]>
Co-authored-by: David Sellén <[email protected]>

* chore: update module federation and more examples (#81)

* fix: #78 (#79)

* fix: #78

* Update src/utils/normalizeOptimizeDeps.ts

Co-authored-by: Sergey Melyukov <[email protected]>

---------

Co-authored-by: 张洪恩 <[email protected]>
Co-authored-by: Sergey Melyukov <[email protected]>

* fix: #77 (#82)

* 1.0.0-alpha-2f53b4e

* docs: update Vue example link

* docs: update React example link

* docs: update README

* fix: Remote virtual module path (#84)

Co-authored-by: 张洪恩 <[email protected]>

* 1.0.0-alpha-c13dc95

* feat: add improvements (#86)

* fix: Remote virtual module path

* examples: nuxt(Unfinished)

* feat: mf-manifest; Register remote on demand

* doc: roadmap

* doc: npm url

* Delete src/utils/getLocalSharedImportMap_windows.ts

---------

Co-authored-by: 张洪恩 <[email protected]>

---------

Co-authored-by: zhn <[email protected]>
Co-authored-by: 张洪恩 <[email protected]>
Co-authored-by: Sergey Melyukov <[email protected]>
Co-authored-by: Sergey Melukov <[email protected]>
Co-authored-by: HG <[email protected]>
Co-authored-by: David sellén <[email protected]>
Co-authored-by: David Sellén <[email protected]>
Co-authored-by: David Sellén <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants