Textarea TV loses Auto Grow and Resizable settings on reload

[eremozin]

Bug Report

Summary

The Textarea TV with Auto Grow and Resizable enabled resets these settings when the TV is reloaded or reopened.

Steps to Reproduce

1. Create a Template Variable (TV) with the input type set to Textarea.
2. Disable Auto Grow and Resizable options.
3. Save and reload or reopen the TV.

Environment

MODX version: 3.1.2-pl

[halftrainedharry]

The problem seems to be the function paramValueIsTrue() that was added with #16553 (in MODX 3.1.0):

revolution/core/src/Revolution/modX.php

Lines 402 to 416 in ba4e3d4

	* Evaluate boolean-like parameter value and return it as an actual boolean or as a string; a string may be
	* needed/preferred when building code blocks (e.g., javascript) via php strings (nowdoc/heredoc ones in particular).
	*
	* @param array $params An associative or numeric-indexed array of parameters
	* @param string|int $key The array key to evaluate
	* @param bool $returnBoolAsString Whether to return the string representation ('true' or 'false') of the boolean value
	* @return string|bool
	*/
	public function paramValueIsTrue(array $params, $key, bool $returnBoolAsString = false)
	{
	if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1])) {
	return $returnBoolAsString ? 'true' : true ;
	}
	return $returnBoolAsString ? 'false' : false ;
	}

Because in_array('false',[true]); seems to return true in PHP, the function returns true when the value is the string 'false'.

[halftrainedharry]

The solution is probably to use the third parameter ($strict) of the in_array function and to change the line

revolution/core/src/Revolution/modX.php

Line 412 in ba4e3d4

if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1])) {

to this instead:

if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1], true)) {

[smg6511]

@halftrainedharry - Yup, thanks for taking a look. I put up a PR to fix it. It is indeed resolved by specifying strict checking. The mystery is, why didn't the problem show up when I added those options a while back? Who knows ;-)