fixing permissions issue on TOTP page

matdave · matdave · commit 56709e0a877a · 2023-01-06T11:47:38.000-06:00
diff --git a/_build/gpm.json b/_build/gpm.json
@@ -3,7 +3,7 @@
   "lowCaseName": "twilio",
   "description": "Twilio for MODX Revolution 3.x",
   "author": "John Peca",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "menus": [
     {
       "text": "twilio.users",
diff --git a/core/components/twilio/controllers/users.class.php b/core/components/twilio/controllers/users.class.php
@@ -3,7 +3,10 @@
 
 class TwilioUsersManagerController extends TwilioBaseManagerController
 {
-    public $permission = 'twilio_manage_auth';
+    public function checkPermissions()
+    {
+        return $this->modx->hasPermission('twilio_manage_auth');
+    }
 
     public function getPageTitle()
     {
diff --git a/core/components/twilio/index.class.php b/core/components/twilio/index.class.php
@@ -6,11 +6,6 @@ abstract class TwilioBaseManagerController extends modManagerController
 {
     public string $version = '1.0.0';
 
-    public function checkPermissions()
-    {
-        return $this->modx->hasPermission('twilio_manage_auth');
-    }
-
     public function initialize()
     {
         $corePath = $this->modx->getOption(

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`"lowCaseName": "twilio",`
`4`	`4`	`"description": "Twilio for MODX Revolution 3.x",`
`5`	`5`	`"author": "John Peca",`
`6`		`- "version": "2.0.1",`
	`6`	`+ "version": "2.0.2",`
`7`	`7`	`"menus": [`
`8`	`8`	`{`
`9`	`9`	`"text": "twilio.users",`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,10 @@`
`3`	`3`
`4`	`4`	`class TwilioUsersManagerController extends TwilioBaseManagerController`
`5`	`5`	`{`
`6`		`- public $permission = 'twilio_manage_auth';`
	`6`	`+ public function checkPermissions()`
	`7`	`+ {`
	`8`	`+ return $this->modx->hasPermission('twilio_manage_auth');`
	`9`	`+ }`
`7`	`10`
`8`	`11`	`public function getPageTitle()`
`9`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,11 +6,6 @@ abstract class TwilioBaseManagerController extends modManagerController`
`6`	`6`	`{`
`7`	`7`	`public string $version = '1.0.0';`
`8`	`8`
`9`		`- public function checkPermissions()`
`10`		`- {`
`11`		`- return $this->modx->hasPermission('twilio_manage_auth');`
`12`		`- }`
`13`		`-`
`14`	`9`	`public function initialize()`
`15`	`10`	`{`
`16`	`11`	`$corePath = $this->modx->getOption(`