fix(deps): pin external git dependencies - #308
Conversation
Signed-off-by: Bhavya Jain <jainbhavya0810@gmail.com>
PR Check Summary
CI will run: build, test, clippy, fmt, cargo-deny, DCO, semver. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe workspace pins the ChangesDependency pinning
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @Bbn08 , The failing
I reproduced This PR changes only the two Git dependency declarations in All checks relevant to this change pass, including formatting, Clippy, documentation, benchmarks, MSRV, semver, unused dependencies, DCO, and the complete workspace test suite locally. I have intentionally not included unrelated security dependency updates in this PR so that it remains focused on issue #272. |
What
mohu-computeto commit9243ba1fcd292adf789b87ed7884f68ab3b6d9fb.mohu-linalgto commit2f4d83969b27a2d0e21f5c90ab92c2b078bb0844.Cargo.toml.Why
The two external workspace dependencies previously referenced only their Git repository URLs. This allowed Cargo to resolve newer commits whenever the repositories’ default branches advanced, reducing build reproducibility across development, CI, and future environments.
Pinning both dependencies with explicit
revvalues ensures that every environment resolves the same reviewed upstream commits.Cargo.lockremains unchanged because these dependencies are declared in[workspace.dependencies]but are not currently inherited by any crate in the resolved workspace dependency graph.Closes #272
How
mainbranch of each external repository.revfield to both Git dependency declarations.upstream/main.cargo deny checkcurrently fails identically on an untouchedupstream/mainworktree because of the following pre-existing advisories:RUSTSEC-2026-0204forcrossbeam-epoch 0.9.18RUSTSEC-2026-0186formemmap2 0.9.10This PR does not modify
Cargo.lockor either affected dependency.Checklist
cargo test --workspacepassescargo clippy --workspace -- -D warningspassescargo fmt --allappliedCHANGELOG.mdupdated (not required; this is not a user-facing change)Summary by CodeRabbit