Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python 3.8? #2476

Closed
ADBond opened this issue Oct 17, 2024 · 0 comments · Fixed by #2520
Closed

Deprecate Python 3.8? #2476

ADBond opened this issue Oct 17, 2024 · 0 comments · Fixed by #2520
Labels
dependencies Pull requests that update a dependency file

Comments

@ADBond
Copy link
Contributor

ADBond commented Oct 17, 2024

Python 3.8 is now end-of-life, receiving no further updates, and so at some point we may also need to drop support for it.

Out current version-compatibility policy suggests an approximate grace period of 6 months before actually implementing the upgrade, so I wonder if now is a good time to introduce a deprecation warning for users who are still operating on python 3.8 so that they have some notice to be able to make upgrades if possible (if they wish to continue to get new Splink versions).

It may well be that we don't need to update the dependency until much later than that. I don't think we really need to take responsibility for ensuring people are using supported python versions, so I think we can probably leave 3.8 in pyproject.toml until:

  • we hit issues with our dependencies being compatible with this version
  • we decide it would be highly beneficial to make use of some language feature not introduced until 3.9
  • it becomes too much work to keep this version working properly (as happened previously with 3.7 and 3.6)
  • some combination of the above

I realise we will have some users who won't be able to upgrade their version of python, but this will only stop them being able to get new Splink versions. Hopefully with this period of deprecation they have time to request features / report bugs that can be addressed before we drop support.

Happy to hear any other opinions on this!

@ADBond ADBond added the dependencies Pull requests that update a dependency file label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant