Deprecation warning for python 3.8 #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADBond
force-pushed
the
maint/deprecate-3-8
branch
from
c999359 to
487aad6
Compare
|
NB you can see this warning in operation in the 3.8 tests if you check the logs. |
|
@RobinL you have any objections to merging this? |
|
No - please go ahead! Thanks! |
ADBond
force-pushed
the
maint/deprecate-3-8
branch
from
487aad6 to
4935da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2476.
As outlined in the linked issue, according to our docs we have a policy of dropping support for python versions after end-of-life, following an additional 6-month grace period.
I don't think we need to drop support for 3.8 any time soon. We don't really need to stop until it becomes too cumbersome to continue to support, which for now it's not. But this will likely change as time goes on - several (maybe most?) of our dependencies don't support 3.8 in their latest releases, so we will probably encounter issues at some point with this mismatch.
I think it will be good to get this deprecation warning in now. It doesn't commit us to any particular timeline, but gives people warning that if they will need to upgrade their python version to continue getting the latest version of Splink. If we start warning now, we should be giving people plenty of notice to be able to manage that upgrade. Then when the time comes that 3.8 becomes difficult to keep supporting we can (potentially) just drop it, as affected users should have had plenty of notice by that point.