-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 4.0.4 #2
Comments
Also, it'd be nice if we could download jemalloc from some more official source. EDIT: You could probably add it to the git repo here and use something like rawgit.com to download from it. |
Agreed, though it needs to be built at some point. Adding it to the git repo would make it available at build time (w/o the download), but would also bloat the repo some, slowing things down. Attaching it to a release might actually do the trick. I'll try creating a release for the current version and adding the binary. (I don't actually use this buildpack--it was to facilitate some experiments a while back, so if you'd like to potentially adopt it, let me know.) |
Yup, looks like that would work: https://github.com/mojodna/heroku-buildpack-jemalloc/releases/tag/v3.6.0 |
@mojodna perhaps could adopt it, let me work a little more with it first. but it works great in production with the new buildpacks features, so I think more people should be looking at this. |
Sweet, keep me posted! |
Hi, any luck with building this? 4.2.1 is already available. |
Simply haven't had time - everything you need in the repo is there if you want to give it a shot! Will accept PRs. |
v5.0.0 just came out today. I'd do a PR for it, but I don't know how the build process works when building for a different environment than my local machine. How has this been done in the past? |
There's a |
0938c22 is largely suitable for a PR (without the line I commented on). |
This allows new versions to be built for uploading by running `make VERSION=5.0.1` rather than updating the hard coded version in multiple places. I've also added support for building against either the legacy cedar-14 architecture or heroku-16. While versions built on cedar-14 appear to run on heroku-16, the newer stack should also mean a newer and better tool chain. I've removed the Dockerfile and switched to using Heroku's docker images directly as this removes the need for cleaning them up afterwards. It possibly makes debugging harder but having build.sh available should avoid some of that. Fixes #2 Fixes #7 Fixes #13
This allows new versions to be built for uploading by running `make VERSION=5.0.1` rather than updating the hard coded version in multiple places. I've also added support for building against either the legacy cedar-14 architecture or heroku-16. While versions built on cedar-14 appear to run on heroku-16, the newer stack should also mean a newer and better tool chain. I've removed the Dockerfile and switched to using Heroku's docker images directly as this removes the need for cleaning them up afterwards. It possibly makes debugging harder but having build.sh available should avoid some of that. Fixes #2 Fixes #7 Fixes #13
After a few months of testing 5.1.0 appears to be stable and working well. It is a recommended upgrade by the jemalloc team. Closes mojodna#2
No description provided.
The text was updated successfully, but these errors were encountered: