-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of mutable kwargs throughout psiflow #14
Comments
Not really, this is inspired by the examples in the Parsl docs. |
Ah, I see. So this related to a Parsl constraint with the |
@svandenhaute: here is a follow up Parsl/parsl#2925 (comment). |
Yeah, I just disabled flake8 to complain about it for now until this is sorted in Parsl. |
psiflow/psiflow/models/base.py
Lines 28 to 34 in e011c2b
There are many instances in Psiflow where the default arguments are mutable objects. Is this intentional? I would imagine that this would be particularly undesirable and that one should do
inputs: List[file] | None = None
followed by something likeinputs = {} if inputs is None else inputs
in the function definition. Are these kwargs intentionally mutable, out of curiosity?The text was updated successfully, but these errors were encountered: