Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No payload in GOAWAY frame #219

Open
ghost opened this issue Sep 20, 2016 · 0 comments
Open

No payload in GOAWAY frame #219

ghost opened this issue Sep 20, 2016 · 0 comments

Comments

@ghost
Copy link

ghost commented Sep 20, 2016

I'm trying to send POST request to Apple Push Notifications server (APN). I'm getting GOAWAY frame without payload data, through APN manual states that it must contain a JSON data.

The code I'm using:

var logger = {
    fatal: noop,
    error: noop,
    warn : noop,
    info : noop,
    debug: function(data) {
        console.log(data);  //GOAWAY frame appears with no payload
    },
    trace: noop,
    child: function() { return this; }
};

var req = http2.request({
    hostname: 'api.push.apple.com',
    protocol: 'https:',
    port: 443,
    method: 'POST',
    path: '/3/device/' + deviceToken,
    agent: new http2.Agent({log: logger}),
    headers: {
        'Authorization': 'bearer ' + providerToken,
        'apns-topic': 'web.com.example'
    }
}, function(res) {
    console.log('done');
    res.pipe(process.stdout);
});
req.write(JSON.stringify(post));
req.end();

Should I do extra actions to get a payload?

Thank you very much for this module!

thughes added a commit to airtimemedia/node-http2 that referenced this issue Mar 7, 2017
Additional debug data is allowed to be included in the GOAWAY frame:
https://http2.github.io/http2-spec/#GOAWAY. We now put that data into
frame.debug_data instead of returning a FRAME_SIZE_ERROR. Fixes molnarg#218
and molnarg#219.
thughes added a commit to airtimemedia/node-http2 that referenced this issue Mar 7, 2017
Additional debug data is allowed to be included in the GOAWAY frame:
https://http2.github.io/http2-spec/#GOAWAY. We now put that data into
frame.debug_data instead of returning a FRAME_SIZE_ERROR. Fixes molnarg#218
and molnarg#219.
florianreinhart pushed a commit to node-apn/node-http2 that referenced this issue Mar 15, 2017
Additional debug data is allowed to be included in the GOAWAY frame:
https://http2.github.io/http2-spec/#GOAWAY. We now put that data into
frame.debug_data instead of returning a FRAME_SIZE_ERROR. Fixes molnarg#218
and molnarg#219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants