Recommendation added twice to a risk after export and reimport of RiskAnalysis in monarc (v2.12.7)

[ritikalux]

Discussed in #543

^{Originally posted by ritikalux October 29, 2024}
If i add a recommendation to a specific risk. Given that the asset instance is connected to multiple branches as an example below.
The recommendation gets added twice after exporting the risk analysis JSON and importing the JSON again to a new risk analysis:

ILR_En_Gas_Supply of natural gas > ILR_En_Gas_Sup_Trading/Purchasing > ILR_En_Gas_Gen_Air conditioning
ILR_En_Gas_Supply of natural gas > ILR_En_Gas_Sup_Customer Management > ILR_En_Gas_Gen_Air conditioning
ILR_En_Gas_Supply of natural gas > ILR_En_Gas_Sup_Market communication > ILR_En_Gas_Gen_Air conditioning

I am attaching a sample JSON where you can see the issue in ILR_En_Gas_Gen_Air conditioning and also a screenshot of the issue.

TemplateGasSupplyonlyWithOneReco.json

The JSON file was generated with an analysis with only one recommendation added to this risk.

[ruslanbaidan]

Thank you for the report.
The issue is not presented in the version 2.13.1.
We are cooperating with your Monarc provider to execute the update as soon as possible or find a solution for your case.

[ruslanbaidan]

Could you tell if it's possible to remove/detach the extra recommendation linked to the risk ?
If both are detached, could you link once again ?
This could be a solution until the new version is available for you.

[ritikalux]

I had tried this solution before posting this request and it works however there are two problems with this workaround:

1. For a very small risk analysis with few recommendations it is a feasible work around. I am however dealing with large risk analysis where it is not possible to do it manually for each recommendation.
2. If I export the JSON and reimport it to a blank risk analysis again the problem reappears thus the problem seems to be in loading logic.
   If the timeline of release of version 2.13.1 is until end of Jan2025 it will certainly work for me.

[ritikalux]

I just noticed that v2.13.1 is already released. I will download this version and verify the fix at my end and is all is good i will close this issue. Thanks a lot.

[ruslanbaidan]

I just noticed that v2.13.1 is already released. I will download this version and verify the fix at my end and is all is good i will close this issue. Thanks a lot.

There is one thing to mention that exported analysis JSON files from v2.13.1 are not compatible to be imported into previous versions. But the opposite way is ok, the older versions files can be imported into v2.13.1.

[ritikalux]

Dear Ruslan, Thanks for the fix. I have verified the issue is fixed in v2.13.1. The loading of JSON file is super fast with this version. Are there some significant changes that went into this release causing the perf improvement ? Just wondering if there could be a functionality impact and I should be doing a validation at my end (maybe not simple to do).

[ruslanbaidan]

The release notes are available on the release page https://github.com/monarc-project/MonarcAppFO/releases/tag/v2.13.1.
Biggest part of the backend and core was redone / refactored, improved.
So it's a huge change of the codebase that was tested and already on our production.
To repeat again, if you would need to send an exported file to an organisation that uses older version of Monarc FrontOffice it will not be possible to import it there.