Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpatching/removing extension doesn't seem to do a complete job #16

Open
nicolasmol opened this issue Sep 23, 2022 · 3 comments
Open

Unpatching/removing extension doesn't seem to do a complete job #16

nicolasmol opened this issue Sep 23, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@nicolasmol
Copy link

nicolasmol commented Sep 23, 2022

After applying unpatch/remove extension, the patch css link does not seem to be removed entirely from workbench.html
image

SIDE QUESTION : where can I find the doc to understand how using of such patching methods ?
It's for developing my own extension.
Thanks

@mondersky
Copy link
Owner

  • hello you're right, the patch doesn't get removed. Ideally some javascript needs to be triggered upon extension uninstall but I haven't found anything in the docs on how to perform this. it's not unlikely to be unachievable. My latest try was using
    "vscode:uninstall": "node ./src/uninstall.js"
  • I haven't found any doc on the internet that explains how to patch vs code, try looking for "how to patch electron" since vs code is based on Electron, I am planning on writing an article on how to patch vs code in the future, I am not sure when but I won't forget to let you know when it's ready
    thanks

@nicolasmol

This comment was marked as off-topic.

@mondersky
Copy link
Owner

Until an automatic method for unpatching VS Code upon extension removal is available, you can run the remove patch command right before uninstalling the extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants