Merge pull request #9982

tobtoht · tobtoht · commit d95cd2633063 · 2025-07-13T16:52:45.000Z
45152f9 rpc: return error correctly on bad key image string (jeffro256)
diff --git a/src/rpc/core_rpc_server.cpp b/src/rpc/core_rpc_server.cpp
@@ -1240,8 +1240,11 @@ namespace cryptonote
       if(b.size() != sizeof(crypto::key_image))
       {
         res.status = "Failed, size of data mismatch";
+        return true;
       }
-      key_images.push_back(*reinterpret_cast<const crypto::key_image*>(b.data()));
+      key_images.emplace_back();
+      crypto::key_image &ki = key_images.back();
+      memcpy(&ki, b.data(), sizeof(crypto::key_image));
     }
     std::vector<bool> spent_status;
     bool r = m_core.are_key_images_spent(key_images, spent_status);

Original file line number	Diff line number	Diff line change
`@@ -1240,8 +1240,11 @@ namespace cryptonote`
`1240`	`1240`	`if(b.size() != sizeof(crypto::key_image))`
`1241`	`1241`	`{`
`1242`	`1242`	`res.status = "Failed, size of data mismatch";`
	`1243`	`+ return true;`
`1243`	`1244`	`}`
`1244`		`- key_images.push_back(reinterpret_cast<const crypto::key_image>(b.data()));`
	`1245`	`+ key_images.emplace_back();`
	`1246`	`+ crypto::key_image &ki = key_images.back();`
	`1247`	`+ memcpy(&ki, b.data(), sizeof(crypto::key_image));`
`1245`	`1248`	`}`
`1246`	`1249`	`std::vector<bool> spent_status;`
`1247`	`1250`	`bool r = m_core.are_key_images_spent(key_images, spent_status);`