Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies between the article and the finish branch. #11

Open
nslee333 opened this issue Dec 17, 2022 · 0 comments
Open

Discrepancies between the article and the finish branch. #11

nslee333 opened this issue Dec 17, 2022 · 0 comments

Comments

@nslee333
Copy link

I found a few discrepancies between the article's code examples and the code in the Finish branch, I have them listed below.

Both cases were in the GET requests in the games.router.ts file.

/src/routes/games.router.ts @ line #12

  • Article example:
const games = (await collections.games.find({}).toArray()) as Game[];
  • Finish branch:
const games = await collections.games.find({}).toArray();

/src/routes/games.router.ts @ line #27

  • Article example:
const game = (await collections.games.findOne(query)) as Game;
  • Finish branch:
const game = await collections.games.findOne(query)

I was going through the tutorial and the article code was throwing errors which lead me to this, anyway just a heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant